[GitHub] [spark] HyukjinKwon commented on a change in pull request #27689: [SPARK-30689][CORE][FOLLOW-UP] Rename config name of discovery plugin

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #27689:
URL: https://github.com/apache/spark/pull/27689#discussion_r426488851



##########
File path: core/src/main/scala/org/apache/spark/resource/ResourceDiscoveryScriptPlugin.scala
##########
@@ -32,6 +33,7 @@ import org.apache.spark.util.Utils.executeAndGetOutput
  * If the user specifies custom plugins, this is the last one to be executed and
  * throws if the resource isn't discovered.
  */
+@DeveloperApi
 class ResourceDiscoveryScriptPlugin extends ResourceDiscoveryPlugin with Logging {

Review comment:
       I just happened to double check these modules. Shall we add `@since` for APIs `ResourceDiscoveryScriptPlugin`, `ResourceInformation`, etc. ?
   
   I remember it was targeted to be APIs for Spark 3.0, and we kind of postponed to Spark 3.1 (?) cc @tgravescs - am I correct? Let's add `@since` for exposed APIs for Spark 3.0 at least.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org