You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "HoustonPutman (via GitHub)" <gi...@apache.org> on 2025/07/21 20:21:02 UTC

[PR] SOLR-17821: Fix error scenario for ShardInstall or Recover [solr]

HoustonPutman opened a new pull request, #3434:
URL: https://github.com/apache/solr/pull/3434

   https://issues.apache.org/jira/browse/SOLR-17821
   
   The scenario:
   - A recover or shard install is called on a shard
   - A non-leader replica succeeds, all else fail
   
   Currently, the following happens:
   - The ZK Shard terms are updated to ensure that all terms are non-zero
   - A failure is returned
   - But the cluster state is unchanged, and all shards are still in the state the started at. Even though not all have the same index
   
   What we want to happen:
   - The ZK Shard terms are updated such that the successful replica(s) are the highest terms
   - Since the leader is no longer the highest term, it should give up leadership
   - All failing replicas should go into Leader-Initiated-Recovery
   - Once recovery has started, our InstallShard/Recovery command can succeed since the results will be what the user expects
     - We can add a `waitForAllReplicasToBeHealthy` option to wait for the recoveries to finish
   
   This requires a few changes:
   
   - [ ]  Obviously we want to fix the Recover and InstallShard commands to update shard terms correctly
   - [ ] Leadership should be given up when the shard term is lower than the highest shard term
   - [ ] Recovery should succeed even though the collection is in read-only mode
   - [ ] The tests should be able to test that the leader fails, and all other replicas succeed
   - [ ] Recover and InstallShard should manipulate the responses, so that the AsyncTracker does not think we are unsuccessful when replicas are put into recovery
   - [ ] We should add flags so that the user can control which replicas to download to, and when the response should be sent back (after recovery or not).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17821: Fix error scenario for ShardInstall or Restore [solr]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3434:
URL: https://github.com/apache/solr/pull/3434#issuecomment-3314264910

   This PR has had no activity for 60 days and is now labeled as stale.  Any new activity will remove the stale label.  To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17821: Fix error scenario for ShardInstall or Recover [solr]

Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #3434:
URL: https://github.com/apache/solr/pull/3434#issuecomment-3098578396

   Some of the code is kind of hacky right now. But the bad stuff shouldn't be too hard to clean up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17821: Fix error scenario for ShardInstall or Restore [solr]

Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #3434:
URL: https://github.com/apache/solr/pull/3434#issuecomment-3099182092

   The implementation works for InstallShard, but we need to add this same functionality to Restore as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17821: Fix error scenario for ShardInstall or Restore [solr]

Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman merged PR #3434:
URL: https://github.com/apache/solr/pull/3434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17821: Fix error scenario for ShardInstall or Restore [solr]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3434:
URL: https://github.com/apache/solr/pull/3434#issuecomment-3549986379

   This PR is now closed due to 60 days of inactivity after being marked as stale.  Re-opening this PR is still possible, in which case it will be marked as active again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17821: Fix error scenario for ShardInstall or Restore [solr]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3434: SOLR-17821: Fix error scenario for ShardInstall or Restore
URL: https://github.com/apache/solr/pull/3434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17821: Fix error scenario for ShardInstall or Restore [solr]

Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #3434:
URL: https://github.com/apache/solr/pull/3434#issuecomment-4291001486

   This is now ready with all of the prerequisite PRs being merged.
   
   @gerlowskija and I were talking and we really do need to converge around a language between `install` and `restore` because now they mean the same thing and shard the same code. So Restore/Install collection/shard/core should all generally be sharing the same language. We can probably do that in a future PR, but it should be called out. (Created a JIRA for this: [SOLR-18204](https://issues.apache.org/jira/browse/SOLR-18204))
   
   I have also created a separate JIRA ([SOLR-18205](https://issues.apache.org/jira/browse/SOLR-18205)) to handle configuring which replicas actually download/install data from the backup repository. (And then Solr can handle the rest of the replication)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org