[GitHub] [spark] cloud-fan commented on a change in pull request #29160: [SPARK-32364][SQL] `path` argument of DataFrame.load/save should override the existing options

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29160:
URL: https://github.com/apache/spark/pull/29160#discussion_r457308708



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -211,6 +211,7 @@ class DataFrameReader private[sql](sparkSession: SparkSession) extends Logging {
    */
   def load(path: String): DataFrame = {
     // force invocation of `load(...varargs...)`
+    removeExtraOptionsByKey("path")

Review comment:
       +1. I don't think an "indeterministic behavior" should be considered in backward compatibility. We should just use `LinkedHashMap`, to solve this problem completely.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org