[GitHub] [samza] rmatharu commented on a change in pull request #1354: SAMZA-2518: Update JobCoordinatorLaunchUtil to fetch launch config from metadata store.

[GitBox <gi...@apache.org>]

rmatharu commented on a change in pull request #1354:
URL: https://github.com/apache/samza/pull/1354#discussion_r418670448



##########
File path: samza-core/src/main/java/org/apache/samza/clustermanager/JobCoordinatorLaunchUtil.java
##########
@@ -57,14 +58,17 @@ public static void run(SamzaApplication app, Config config) {
       throw new SamzaException("Only support single remote job is supported.");
     }
 
-    Config finalConfig = jobConfigs.get(0);
+    Config fullConfig = jobConfigs.get(0);
+    MetricsRegistryMap metrics = new MetricsRegistryMap();
+    MetadataStore

Review comment:
       nit pick: new CoordinatorStreamStore(CoordinatorStreamUtil.buildCoordinatorStreamConfig(fullConfig), new MetricsRegistryMap());




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org