You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/20 08:45:27 UTC

[GitHub] [skywalking] songzhendong commented on a change in pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

songzhendong commented on a change in pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#discussion_r457185458



##########
File path: dist-material/release-docs/NOTICE
##########
@@ -838,7 +838,43 @@ from and not be held liable to the user for any such damages as noted
 above as far as the program is concerned.
 
 ------
+===========================================================================
+nacos-1.3.0 Notice
+===========================================================================
+Nacos
+Copyright 2018-2019 The Apache Software Foundation

Review comment:
       > The PR becomes messy and removes lots of commits from the upstream, I suggest to rebase or simply revert #4867 first and then upgrade the Nacos version immediately, the latter would be more friendly to reviewers
   
   thanks for reviews




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org