You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2016/04/06 18:13:25 UTC

[GitHub] activemq-artemis pull request: ARTEMIS-471 NPE during replication

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/441

    ARTEMIS-471 NPE during replication

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-471

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #441
    
----
commit c7df1b805f946d6dc0be9bf0deaf989a278cf2c8
Author: jbertram <jb...@apache.org>
Date:   2016-04-06T16:12:57Z

    ARTEMIS-471 NPE during replication

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-471 NPE during replication

Posted by jbertram <gi...@git.apache.org>.
Github user jbertram closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/441


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-471 NPE during replication

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/441#discussion_r58762631
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java ---
    @@ -464,7 +464,9 @@ private void sendJournalFile(JournalFile[] journalFiles, JournalContent type) th
           for (JournalFile jf : journalFiles) {
              if (!started)
                 return;
    --- End diff --
    
    Replicator currentReplicator = replicator;
    if (currentReplicator != null) ...
    
    
    There's no lock in place ... you could have a case where it satisfies the if and you still get the NPE.. I have seen it happening before in similar cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---