You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/04 02:31:38 UTC
[GitHub] [flink] lirui-apache commented on a change in pull request #10401:
[FLINK-15020][hive] Support timestamp type in hive
lirui-apache commented on a change in pull request #10401: [FLINK-15020][hive] Support timestamp type in hive
URL: https://github.com/apache/flink/pull/10401#discussion_r353522564
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTypeUtil.java
##########
@@ -274,6 +274,9 @@ public TypeInfo visit(DateType dateType) {
@Override
public TypeInfo visit(TimestampType timestampType) {
+ if (timestampType.getPrecision() != 9) {
Review comment:
Ideally yes, we should support any ts(<=9). But to do that, we need a way to store the precision of timestamp in HMS, and restore the precision when retrieving the table schema. I prefer to leave it to follow up tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services