You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/06/22 11:15:53 UTC
[PR] Update AGENTS.md [shardingsphere]
terrymanu opened a new pull request, #38885:
URL: https://github.com/apache/shardingsphere/pull/38885
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update AGENTS.md [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #38885:
URL: https://github.com/apache/shardingsphere/pull/38885#issuecomment-4767787871
### Summary
**Review Result: Mergeable**
Reason: This is a focused `AGENTS.md` update. The patch narrows the database protocol evidence gate, clarifies E2E rerun discipline, and fixes generic agent-instruction placeholders without introducing conflicting project rules or unrelated scope.
### Evidence
- `AGENTS.md:77` generalizes the interface-only test rule from one concrete example to pure contracts/SPI interfaces while still requiring behavior coverage through concrete implementations.
- `AGENTS.md:151` to `AGENTS.md:179` makes the protocol/client evidence gate explicitly database-protocol scoped and preserves the requirement to continue correlation before changing protocol implementation code.
- `AGENTS.md:181` to `AGENTS.md:190` adds a slow-loop fuse for E2E/integration failures without weakening the existing dangerous-operation or scope-expansion gates.
- `AGENTS.md:329` to `AGENTS.md:337` keeps verification command examples consistent with the surrounding placeholder style.
- No linked issue is claimed, and GitHub `/pulls/38885/files` matches the local triple-dot scope: only `AGENTS.md` changed.
### Review Details
- Reviewed Scope: PR #38885 latest head `c803297add3d0878499d45984fb631d63a9dbceb`, base `master` at `4724ae333fe355afb050186d71709a960fc92c14`, merge-base `4724ae333fe355afb050186d71709a960fc92c14`; reviewed `AGENTS.md`; local file list matched GitHub `/pulls/38885/files`.
- Not Reviewed Scope: No Java production/test code, parser grammar, runtime behavior, dependency, distribution, or release artifact scope was changed.
- Verification: `git diff --check refs/remotes/apache/master...refs/remotes/terrymanu/pr-38885 -- AGENTS.md` exit 0; review inventory script exit 0; `./mvnw spotless:check -Pcheck -T1C` exit 0; `./mvnw apache-rat:check -Pcheck -T1C` exit 0; `./mvnw checkstyle:check -Pcheck -T1C` exit 0. Public GitHub Spotless was successful at review time; CheckStyle and License were still running, with local equivalents passing.
- Release Note / User Docs: Not required. This updates AI-agent contributor instructions only and does not change user-facing ShardingSphere behavior, configuration, APIs, protocols, or migration guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update AGENTS.md [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #38885:
URL: https://github.com/apache/shardingsphere/pull/38885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org