You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "fantonangeli (via GitHub)" <gi...@apache.org> on 2025/05/01 22:42:42 UTC

[PR] kie-tools-issues#3097: [SonataFlow] Dev UI does not render object input [incubator-kie-tools]

fantonangeli opened a new pull request, #3100:
URL: https://github.com/apache/incubator-kie-tools/pull/3100

   Closes https://github.com/apache/incubator-kie-tools/issues/3097
   
   **Description:**
   In the data input schema, when we define an input parameter of type object the Dev UI does not render it correctly
   
    ```
    {
       "$id": "classpath:/schemas/create-ocp-project-schema.json",
       "title": "Workflow input data",
       "$schema": "http://json-schema.org/draft-07/schema#",
       "type": "object",
       "properties": {
         "owner": {
           "title": "owner",
           "description": "OCP project to create",
           "type": "string"
         },
         "repo": {
           "title": "repo",
           "description": "OCP project to create",
           "type": "string"
         },
         "baseBranch": {
           "title": "baseBranch",
           "description": "OCP project to create",
           "type": "string"
         },
         "targetBranch": {
           "title": "targetBranch",
           "description": "OCP project to create",
           "type": "string"
         },
         "obj": {
           "title": "obj",
           "description": "test",
           "type": "object"
         }
       },
       "required": [
         "owner",
         "repo",
         "baseBranch",
         "targetBranch"
   
       ]
     }
   ```
   
   
   
   but in the dev UI I am not able to fill it
   
   **Preview:**
   ![image](https://github.com/user-attachments/assets/0b4ec555-d0c5-4243-bd3d-30a0e426e4ca)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-tools-issues#3097: [SonataFlow] Dev UI does not render object input [incubator-kie-tools]

Posted by "fantonangeli (via GitHub)" <gi...@apache.org>.
fantonangeli commented on PR #3100:
URL: https://github.com/apache/incubator-kie-tools/pull/3100#issuecomment-2850392282

   I just discovered I pushed this branch on `upstream` and `origin`, by mistake . 
   I will delete `upstream/kie-tools-issues#3097-SonataFlow-Dev-UI-does-not-render-object-input` and reopen a new PR with the right branch from my fork.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-tools-issues#3097: [SonataFlow] Dev UI does not render object input [incubator-kie-tools]

Posted by "fantonangeli (via GitHub)" <gi...@apache.org>.
fantonangeli commented on PR #3100:
URL: https://github.com/apache/incubator-kie-tools/pull/3100#issuecomment-2850129017

   > Asking @ljmotta's assessment here since he knows a great deal about `uniforms-patternfly`.
   > 
   > From a first glance, I might be inclined to say `uniforms-patternfly` should rely on https://v5-archive.patternfly.org/components/code-editor instead of `@kie-tools/monaco-editor`. WDYT @fantonangeli?
   
   @tiagobento thanks a lot for this suggestion. I think Patterfly's code-editor can be easier to include and test on the jest side. In addition to that, not relying on  `@kie-tools/monaco-editor` can possibly keep `uniforms-patternfly` easier to use on non KIE projects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-tools-issues#3097: [SonataFlow] Dev UI does not render object input [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #3100:
URL: https://github.com/apache/incubator-kie-tools/pull/3100#issuecomment-2848186632

   Asking @ljmotta's assessment here since he knows a great deal about `uniforms-patternfly`.
   
   From a first glance, I might be inclined to say `uniforms-patternfly` should rely on https://v5-archive.patternfly.org/components/code-editor instead of `@kie-tools/monaco-editor`. WDYT @fantonangeli?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-tools-issues#3097: [SonataFlow] Dev UI does not render object input [incubator-kie-tools]

Posted by "fantonangeli (via GitHub)" <gi...@apache.org>.
fantonangeli closed pull request #3100: kie-tools-issues#3097: [SonataFlow] Dev UI does not render object input
URL: https://github.com/apache/incubator-kie-tools/pull/3100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org