You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/01/13 23:08:51 UTC
[GitHub] [ozone] hanishakoneru opened a new pull request #1793: HDDS-4680. Change default OM Node ID from UUID to a constant
hanishakoneru opened a new pull request #1793:
URL: https://github.com/apache/ozone/pull/1793
## What changes were proposed in this pull request?
If a nodeID is not set explicitly (for a single node OM cluster), then it defaults to the OM storage ID which is an UUID string. Proposing to change this default to a constant (such as "om1") instead.
This would help when a cluster is upgraded to HA for example. It is not straightforward to change the nodeID after Ratis server has been instantiated (as the nodeID is used to generate the RaftPeerID). Hence, it would be good to have a more readable nodeID by default.
Note that existing single node Ratis enabled OM clusters will have to set the nodeId explicitly if upgraded.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4680
## How was this patch tested?
Manually tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] hanishakoneru merged pull request #1793: HDDS-4680. Change default OM Node ID from UUID to a constant
Posted by GitBox <gi...@apache.org>.
hanishakoneru merged pull request #1793:
URL: https://github.com/apache/ozone/pull/1793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] hanishakoneru commented on a change in pull request #1793: HDDS-4680. Change default OM Node ID from UUID to a constant
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on a change in pull request #1793:
URL: https://github.com/apache/ozone/pull/1793#discussion_r557596244
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##########
@@ -343,6 +343,7 @@ private OzoneConsts() {
// Default OMServiceID for OM Ratis servers to use as RaftGroupId
public static final String OM_SERVICE_ID_DEFAULT = "omServiceIdDefault";
+ public static final String OM_DEFAULT_NODE_ID = "om1";
// Dummy OMNodeID for OM Clients to use for a non-HA OM setup
public static final String OM_NODE_ID_DUMMY = "omNodeIdDummy";
Review comment:
OM_NODE_ID_DUMMY was being used just as a dummy nodeId in OMFailoverProxyProvider for non-HA cluster.
But now that we have a default, we should remove the dummy. It would not affect the client in anyway as this is only for the non-HA and also.
Thanks for pointing this out Arpit. I will update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] hanishakoneru commented on a change in pull request #1793: HDDS-4680. Change default OM Node ID from UUID to a constant
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on a change in pull request #1793:
URL: https://github.com/apache/ozone/pull/1793#discussion_r557567773
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##########
@@ -343,6 +343,7 @@ private OzoneConsts() {
// Default OMServiceID for OM Ratis servers to use as RaftGroupId
public static final String OM_SERVICE_ID_DEFAULT = "omServiceIdDefault";
+ public static final String OM_DEFAULT_NODE_ID = "om1";
// Dummy OMNodeID for OM Clients to use for a non-HA OM setup
public static final String OM_NODE_ID_DUMMY = "omNodeIdDummy";
Review comment:
No, this would be used for single node Ratis also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] arp7 commented on a change in pull request #1793: HDDS-4680. Change default OM Node ID from UUID to a constant
Posted by GitBox <gi...@apache.org>.
arp7 commented on a change in pull request #1793:
URL: https://github.com/apache/ozone/pull/1793#discussion_r557524821
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##########
@@ -343,6 +343,7 @@ private OzoneConsts() {
// Default OMServiceID for OM Ratis servers to use as RaftGroupId
public static final String OM_SERVICE_ID_DEFAULT = "omServiceIdDefault";
+ public static final String OM_DEFAULT_NODE_ID = "om1";
// Dummy OMNodeID for OM Clients to use for a non-HA OM setup
public static final String OM_NODE_ID_DUMMY = "omNodeIdDummy";
Review comment:
I assume this `omNodeIdDummy` will only be use if someone disables Ratis?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] hanishakoneru commented on a change in pull request #1793: HDDS-4680. Change default OM Node ID from UUID to a constant
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on a change in pull request #1793:
URL: https://github.com/apache/ozone/pull/1793#discussion_r557596244
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##########
@@ -343,6 +343,7 @@ private OzoneConsts() {
// Default OMServiceID for OM Ratis servers to use as RaftGroupId
public static final String OM_SERVICE_ID_DEFAULT = "omServiceIdDefault";
+ public static final String OM_DEFAULT_NODE_ID = "om1";
// Dummy OMNodeID for OM Clients to use for a non-HA OM setup
public static final String OM_NODE_ID_DUMMY = "omNodeIdDummy";
Review comment:
OM_NODE_ID_DUMMY was being used just as a dummy nodeId in OMFailoverProxyProvider for non-HA cluster.
But now that we have a default, we should remove the dummy. It would not affect the client in anyway as this is only for non-HA.
Thanks for pointing this out Arpit. I will update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] arp7 commented on a change in pull request #1793: HDDS-4680. Change default OM Node ID from UUID to a constant
Posted by GitBox <gi...@apache.org>.
arp7 commented on a change in pull request #1793:
URL: https://github.com/apache/ozone/pull/1793#discussion_r557583948
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##########
@@ -343,6 +343,7 @@ private OzoneConsts() {
// Default OMServiceID for OM Ratis servers to use as RaftGroupId
public static final String OM_SERVICE_ID_DEFAULT = "omServiceIdDefault";
+ public static final String OM_DEFAULT_NODE_ID = "om1";
// Dummy OMNodeID for OM Clients to use for a non-HA OM setup
public static final String OM_NODE_ID_DUMMY = "omNodeIdDummy";
Review comment:
Sorry I didn't understand then - how do we use both `OM_DEFAULT_NODE_ID` and `OM_NODE_ID_DUMMY ` with single node Ratis?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org