You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2024/01/18 15:10:35 UTC
(superset) 04/09: fix(embedded): Hide dashboard fullscreen option for embedded context (#26412)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 21ba6caaecc4c28929007c1dc53f1b94f4c67322
Author: Vitor Avila <96...@users.noreply.github.com>
AuthorDate: Thu Jan 11 16:44:12 2024 -0300
fix(embedded): Hide dashboard fullscreen option for embedded context (#26412)
(cherry picked from commit 494068b6325054be076e994ca06e01efdfe83aec)
---
.../HeaderActionsDropdown/HeaderActionsDropdown.test.tsx | 16 ++++++++++++++++
.../components/Header/HeaderActionsDropdown/index.jsx | 4 +++-
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
index 218e2e4546..84a5bd543d 100644
--- a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
+++ b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
@@ -92,6 +92,14 @@ const editModeOnWithFilterScopesProps = {
},
};
+const guestUserProps = {
+ ...createProps(),
+ dashboardInfo: {
+ ...createProps().dashboardInfo,
+ userId: undefined,
+ },
+};
+
function setup(props: HeaderDropdownProps) {
return render(
<div className="dashboard-header">
@@ -133,6 +141,14 @@ test('should render the menu items in edit mode', async () => {
expect(screen.getByText('Edit CSS')).toBeInTheDocument();
});
+test('should render the menu items in Embedded mode', async () => {
+ setup(guestUserProps);
+ expect(screen.getAllByRole('menuitem')).toHaveLength(3);
+ expect(screen.getByText('Refresh dashboard')).toBeInTheDocument();
+ expect(screen.getByText('Download')).toBeInTheDocument();
+ expect(screen.getByText('Set auto-refresh interval')).toBeInTheDocument();
+});
+
describe('with native filters feature flag disabled', () => {
beforeAll(() => {
isFeatureEnabledMock = jest
diff --git a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
index 3f2caab72a..ce40c9319c 100644
--- a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
+++ b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
@@ -236,6 +236,8 @@ class HeaderActionsDropdown extends React.PureComponent {
const emailSubject = `${emailTitle} ${dashboardTitle}`;
const emailBody = t('Check out this dashboard: ');
+ const isEmbedded = !dashboardInfo?.userId;
+
const url = getDashboardUrl({
pathname: window.location.pathname,
filters: getActiveFilters(),
@@ -257,7 +259,7 @@ class HeaderActionsDropdown extends React.PureComponent {
{t('Refresh dashboard')}
</Menu.Item>
)}
- {!editMode && (
+ {!editMode && !isEmbedded && (
<Menu.Item
key={MENU_KEYS.TOGGLE_FULLSCREEN}
onClick={this.handleMenuClick}