[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11816: feat: allow user to view their profile again

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #11816:
URL: https://github.com/apache/incubator-superset/pull/11816#discussion_r530701064



##########
File path: superset-frontend/src/components/Menu/Menu.tsx
##########
@@ -195,8 +196,15 @@ export function Menu({
                 {!navbarRight.user_is_anonymous && [
                   <DropdownMenu.Divider key="user-divider" />,
                   <DropdownMenu.ItemGroup key="user-section" title={t('User')}>
-                    <DropdownMenu.Item key="profile">
-                      <a href={navbarRight.user_info_url}>{t('Profile')}</a>
+                    {navbarRight.user_profile_url && (
+                      <DropdownMenu.Item key="profile">
+                        <a href={navbarRight.user_profile_url}>
+                          {t('Profile')}
+                        </a>
+                      </DropdownMenu.Item>
+                    )}
+                    <DropdownMenu.Item key="edit">
+                      <a href={navbarRight.user_info_url}>{t('Edit')}</a>

Review comment:
       Really? When would a user ever not be able to change their name?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org