You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by jwest-apigee <gi...@git.apache.org> on 2015/06/05 22:40:52 UTC
[GitHub] incubator-usergrid pull request: Updated timer names and added .ti...
GitHub user jwest-apigee opened a pull request:
https://github.com/apache/incubator-usergrid/pull/269
Updated timer names and added .timer and .meter to the factory to create them
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwest-apigee/incubator-usergrid two-dot-o-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-usergrid/pull/269.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #269
----
commit 179e0062d095eb998386b2066c91e223c812e40c
Author: Jeff West <jw...@apigee.com>
Date: 2015-06-05T18:31:22Z
renamed JMX counters/timers, moved some to be instance attributes vs local attributes, defined in method
commit e5c613ebb0daab9e11981b5ef5691949048c43bf
Author: Jeff West <jw...@apigee.com>
Date: 2015-06-05T18:37:57Z
Merge branch 'two-dot-o-dev' of github.com:apache/incubator-usergrid into two-dot-o-dev
# By Shawn Feldman (4) and Todd Nine (2)
# Via Shawn Feldman (2) and Todd Nine (1)
* 'two-dot-o-dev' of github.com:apache/incubator-usergrid:
observable test
remove keyspace dependency
remove keyspace dependency
new name strategy
Fixes issue with ignored compaction operation on edge delete
Adds meta support on GET. The delete is not working correctly.
commit ca28a4aa4c016ed1a65a6f71eafeed883cb87354
Author: Jeff West <jw...@apigee.com>
Date: 2015-06-05T19:00:29Z
updated timer name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Updated timer names and added .ti...
Posted by tnine <gi...@git.apache.org>.
Github user tnine commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/269#discussion_r31929564
--- Diff: stack/services/src/main/java/org/apache/usergrid/services/notifications/impl/ApplicationQueueManagerImpl.java ---
@@ -175,13 +179,13 @@ public void queueNotification(final Notification notification, final JobExecutio
//process up to 10 concurrently
Observable o = rx.Observable.create( new IteratorObservable<Entity>( iterator ) )
- .flatMap( entity -> Observable.just( entity ).map( entityListFunct )
- .doOnError( throwable -> {
- LOG.error( "Failed while writing",
- throwable );
- } ).subscribeOn( Schedulers.io() )
+ .flatMap(entity -> Observable.just(entity).map(entityListFunct)
+ .doOnError(throwable -> {
+ LOG.error("Failed while writing",
+ throwable);
+ }).subscribeOn(Schedulers.io())
--- End diff --
Since we block on line 190, we won't need to subscribe on Schedulers.io(). I know you didn't add this, but can we remove it since we're spinning up another thread that we don't need?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Updated timer names and added .ti...
Posted by tnine <gi...@git.apache.org>.
Github user tnine commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/269#issuecomment-110427743
LGTM. I'll ack this later today when I merge other PRs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Updated timer names and added .ti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-usergrid/pull/269
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---