You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/04 00:16:59 UTC
[I] [Bug] Proxy remoting expired request cleanup silently swallows exceptions [rocketmq]
Aias00 opened a new issue, #10806:
URL: https://github.com/apache/rocketmq/issues/10806
### Problem
`RemotingProtocolServer.cleanExpiredRequestInQueue` catches `Throwable` and ignores it while staying inside a `while (true)` cleanup loop. If queue inspection, task casting, or response cleanup repeatedly throws, the failure is invisible and the cleaner can keep looping without actionable diagnostics.
### Code evidence
- `proxy/src/main/java/org/apache/rocketmq/proxy/remoting/RemotingProtocolServer.java`: `cleanExpiredRequestInQueue` wraps the queue cleanup loop in `catch (Throwable ignored) {}`.
### Impact
Proxy operators lose the diagnostic signal for expired request cleanup failures. In the worst case, repeated exceptions can hide queue cleanup failure or cause avoidable loop churn, which works against Proxy Admin/runtime diagnostics and remoting observability.
### Expected behavior
The cleanup path should log a compact warning with queue context and stop the current cleanup pass after an unexpected exception, rather than swallowing the error silently.
### Scope
RocketMQ Studio track 2 / Proxy Admin runtime diagnostics and Proxy remoting observability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] Proxy remoting expired request cleanup silently swallows exceptions [rocketmq]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #10806:
URL: https://github.com/apache/rocketmq/issues/10806#issuecomment-5190413970
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
**Root Cause:** `RemotingExceptionHandler.handleExpired()` calls `future.release()` inside a try-catch that silently swallows `Throwable`. The `finally` block in `RequestTask.run()` also swallows `future.release()` failures.
**Impact:** Operational — resource leaks and lost diagnostics when request cleanup fails
**Severity:** Medium
The issue is valid. Both the `handleExpired()` path and the `finally` block in `RequestTask.run()` need proper error handling. The proposed fix (logging at WARN level, completing futures exceptionally instead of releasing them) is correct.
An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by @RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] Proxy remoting expired request cleanup silently swallows exceptions [rocketmq]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #10806:
URL: https://github.com/apache/rocketmq/issues/10806#issuecomment-5244921663
**Feedback Timeout**\n\nNo feedback was received within 72 hours. The automated fix proposal has been closed.\n\nIf you'd like to proceed with a fix, please reply to this issue and a maintainer will review it.\n\n---\n*Automated timeout by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org