You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/25 20:18:44 UTC

[GitHub] [tvm] masahi commented on a diff in pull request #13198: [MetaSchedule][Minor] Fix Memory Database Module Equality

masahi commented on code in PR #13198:
URL: https://github.com/apache/tvm/pull/13198#discussion_r1004927019


##########
src/meta_schedule/database/memory_database.cc:
##########
@@ -71,7 +71,7 @@ class MemoryDatabaseNode : public DatabaseNode {
       if (run_secs.empty()) {
         continue;
       }
-      if (record->workload.same_as(workload)) {
+      if (WorkloadEqual(GetModuleEquality())(record->workload, workload)) {

Review Comment:
   What does it fix? They don't seem equivalent (pointer vs structural equality) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org