[GitHub] [beam] Abacn commented on a diff in pull request #24272: Support for JsonSchema in Kafka Read Schema Transform

[GitBox <gi...@apache.org>]

Abacn commented on code in PR #24272:
URL: https://github.com/apache/beam/pull/24272#discussion_r1026983756


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -678,6 +680,8 @@ class BeamModulePlugin implements Plugin<Project> {
         joda_time                                   : "joda-time:joda-time:2.10.10",
         jsonassert                                  : "org.skyscreamer:jsonassert:1.5.0",
         jsr305                                      : "com.google.code.findbugs:jsr305:$jsr305_version",
+        json_org                                    : "org.json:json:${json_org_version}",

Review Comment:
   Thanks for the change! We already have a couple of json parser dependencies (e.g. jackson, gson, fastjson) throughout beam project. And there is some voice to reduce them (#24154). Could one (or some) of these libs satisfy the need of functionality here, or it is necessary to introduce these new deps?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org