You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ashutosh Chauhan (JIRA)" <ji...@apache.org> on 2014/04/17 17:53:15 UTC
[jira] [Commented] (HIVE-4576) templeton.hive.properties does not
allow values with commas
[ https://issues.apache.org/jira/browse/HIVE-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973089#comment-13973089 ]
Ashutosh Chauhan commented on HIVE-4576:
----------------------------------------
Seems like blindly replacing \ after split may run into problems if \ is used in non-escaping context , eg windows path like D:\hive\hive-site.xml or may be I am misreading the patch.
> templeton.hive.properties does not allow values with commas
> -----------------------------------------------------------
>
> Key: HIVE-4576
> URL: https://issues.apache.org/jira/browse/HIVE-4576
> Project: Hive
> Issue Type: Bug
> Components: WebHCat
> Affects Versions: 0.5.0
> Reporter: Vitaliy Fuks
> Assignee: Eugene Koifman
> Priority: Minor
> Attachments: HIVE-4576.patch
>
>
> templeton.hive.properties accepts a comma-separated list of key=value property pairs that will be passed to Hive.
> However, this makes it impossible to use any "value" that itself has a comma in it.
> For example:
> {code:xml}<property>
> <name>templeton.hive.properties</name>
> <value>hive.metastore.sasl.enabled=false,hive.metastore.uris=thrift://foo1.example.com:9083,foo2.example.com:9083</value>
> </property>{code}
> {noformat}templeton: starting [/usr/bin/hive, --service, cli, --hiveconf, hive.metastore.sasl.enabled=false, --hiveconf, hive.metastore.uris=thrift://foo1.example.com:9083, --hiveconf, foo2.example.com:9083 etc..{noformat}
> because the value is parsed using standard org.apache.hadoop.conf.Configuration.getStrings() call which simply splits on commas from here:
> {code:java}for (String prop : appConf.getStrings(AppConfig.HIVE_PROPS_NAME)){code}
> This is problematic for any hive property that itself has multiple values, such as hive.metastore.uris above or hive.aux.jars.path.
> There should be some way to "escape" commas or a different delimiter should be used.
> NO PRECOMMIT TESTS
--
This message was sent by Atlassian JIRA
(v6.2#6252)