[GitHub] spark pull request #23024: [SPARK-26044][WEBUI]Aggregated Metrics table sort...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23024#discussion_r233499408
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/ExecutorTable.scala ---
    @@ -92,16 +93,7 @@ private[ui] class ExecutorTable(stage: StageData, store: AppStatusStore) {
         executorSummary.toSeq.sortBy(_._1).map { case (k, v) =>
           val executor = store.asOption(store.executorSummary(k))
           <tr>
    -        <td>
    -          <div style="float: left">{k}</div>
    -          <div style="float: right">
    -          {
    -            executor.map(_.executorLogs).getOrElse(Map.empty).map {
    -              case (logName, logUrl) => <div><a href={logUrl}>{logName}</a></div>
    -            }
    -          }
    -          </div>
    -        </td>
    +        <td>{if (k == "driver") k else k.toInt} </td>
    --- End diff --
    
    I'm curious, why does .toInt matter here? it ends up the same in the HTML, no?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org