[GitHub] [spark] cloud-fan commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

[GitBox <gi...@apache.org>]

cloud-fan commented on pull request #29497:
URL: https://github.com/apache/spark/pull/29497#issuecomment-679242942


   I'm +1 to this idea, error message is super important to end-users, as it tells them what went wrong and how to fix it. It's easier to audit them if they are grouped together.
   
   We need a clear way to organize it. This PR proposes `org.apache.spark.sql.CatalystErrors` for sql/catalyst, but how about sql/core, sql/hive and thriftserver? In general, there are 2 kinds of errors: query compilation error and query execution error, shall we group them separately?
   
   one idea is to use different package names for different modules:
   ```
   org.apache.spark.sql.catalyst.QueryCompilationErrors
   org.apache.spark.sql.catalyst.QueryExecutionErrors
   org.apache.spark.sql.QueryCompilationErrors
   org.apache.spark.sql.QueryExecutionErrors
   org.apache.spark.sql.hive.QueryCompilationErrors
   org.apache.spark.sql.hive.QueryExecutionErrors
   ...
   ```
   
   I'm open to other ideas as well. cc @maropu @viirya @dongjoon-hyun 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org