You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "vaibhavarya1622 (via GitHub)" <gi...@apache.org> on 2023/08/13 20:31:28 UTC
[PR] Issue #4203 (eventmesh)
vaibhavarya1622 opened a new pull request, #4357:
URL: https://github.com/apache/eventmesh/pull/4357
Fixes #4203 .
### Motivation
Fixes the issue #4203
### Modifications
Fixes the issue #4203
### Documentation
- Does this pull request introduce a new feature? ( no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4203] [Enhancement] Do some code optimization.[EventMeshTcpMessageDispatcher] (eventmesh)
Posted by "vaibhavarya1622 (via GitHub)" <gi...@apache.org>.
vaibhavarya1622 commented on PR #4357:
URL: https://github.com/apache/eventmesh/pull/4357#issuecomment-1677783126
@mxsm CI issue has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4203] [Enhancement] Do some code optimization.[EventMeshTcpMessageDispatcher] (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm merged PR #4357:
URL: https://github.com/apache/eventmesh/pull/4357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4203] [Enhancement] Do some code optimization.[EventMeshTcpMessageDispatcher] (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4357:
URL: https://github.com/apache/eventmesh/pull/4357#issuecomment-1678200463
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4357](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (090aa3a) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/dbfb57156320901eac59714fe0334701cefe2cb8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dbfb571) will **increase** coverage by `0.05%`.
> Report is 5 commits behind head on master.
> The diff coverage is `27.17%`.
> :exclamation: Current head 090aa3a differs from pull request most recent head 8a12460. Consider uploading reports for the commit 8a12460 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4357 +/- ##
============================================
+ Coverage 17.74% 17.80% +0.05%
- Complexity 1500 1503 +3
============================================
Files 594 595 +1
Lines 25351 25359 +8
Branches 2395 2376 -19
============================================
+ Hits 4498 4514 +16
+ Misses 20419 20412 -7
+ Partials 434 433 -1
```
| [Files Changed](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../apache/eventmesh/common/enums/ConnectionType.java](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9lbnVtcy9Db25uZWN0aW9uVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...core/protocol/grpc/consumer/EventMeshConsumer.java](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9jb25zdW1lci9FdmVudE1lc2hDb25zdW1lci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...tocol/grpc/processor/SubscribeStreamProcessor.java](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wcm9jZXNzb3IvU3Vic2NyaWJlU3RyZWFtUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ime/core/protocol/grpc/push/StreamPushRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wdXNoL1N0cmVhbVB1c2hSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...re/protocol/http/processor/AsyncHttpProcessor.java](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvQXN5bmNIdHRwUHJvY2Vzc29yLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../protocol/http/processor/CreateTopicProcessor.java](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvQ3JlYXRlVG9waWNQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/core/protocol/http/processor/HandlerService.java](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvSGFuZGxlclNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ocol/tcp/client/EventMeshTcpMessageDispatcher.java](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9FdmVudE1lc2hUY3BNZXNzYWdlRGlzcGF0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ache/eventmesh/runtime/util/HttpResponseUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3V0aWwvSHR0cFJlc3BvbnNlVXRpbHMuamF2YQ==) | `23.07% <0.00%> (ø)` | |
| [...mesh/webhook/admin/FileWebHookConfigOperation.java](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXdlYmhvb2svZXZlbnRtZXNoLXdlYmhvb2stYWRtaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC93ZWJob29rL2FkbWluL0ZpbGVXZWJIb29rQ29uZmlnT3BlcmF0aW9uLmphdmE=) | `43.20% <0.00%> (ø)` | |
| ... and [5 more](https://app.codecov.io/gh/apache/eventmesh/pull/4357?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4357/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org