You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by Sean Mackrory <ma...@gmail.com> on 2013/09/03 15:46:09 UTC
Review Request 13943: BIGTOP-939: Moving Tomcat configuration under /etc,
deploying to /var at run-time.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13943/
-----------------------------------------------------------
Review request for bigtop.
Bugs: BIGTOP-939
https://issues.apache.org/jira/browse/BIGTOP-939
Repository: bigtop
Description
-------
See JIRA for details...
Diffs
-----
bigtop-packages/src/common/hadoop/hadoop-httpfs.svc de4d6d2
bigtop-packages/src/common/hadoop/httpfs.default e48e608
bigtop-packages/src/common/hadoop/install_hadoop.sh 08ddb52
bigtop-packages/src/common/oozie/install_oozie.sh c27dd64
bigtop-packages/src/common/oozie/oozie-env.sh dd051f7
bigtop-packages/src/common/oozie/oozie.init 4600841
bigtop-packages/src/common/solr/install_solr.sh 3e27c3b
bigtop-packages/src/common/solr/solr-server.init.debian 5b8b862
bigtop-packages/src/common/sqoop/install_sqoop.sh df4f489
bigtop-packages/src/common/sqoop/sqoop-server.sh b1de301
bigtop-packages/src/common/sqoop/sqoop.default cdec81c
bigtop-packages/src/deb/hadoop/hadoop-httpfs.install fe1a462
bigtop-packages/src/deb/oozie/oozie.postinst 23decab
bigtop-packages/src/deb/oozie/rules bb1e6c0
bigtop-packages/src/deb/sqoop/sqoop.install 0386c7a
bigtop-packages/src/rpm/hadoop/SPECS/hadoop.spec acfc2fa
bigtop-packages/src/rpm/oozie/SPECS/oozie.spec 4bbc212
bigtop-packages/src/rpm/solr/SOURCES/solr-server.init 6d1a035
bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 5f4447b
Diff: https://reviews.apache.org/r/13943/diff/
Testing
-------
See JIRA for details...
Thanks,
Sean Mackrory
Re: Review Request 13943: BIGTOP-939: Moving Tomcat configuration under /etc,
deploying to /var at run-time.
Posted by Sean Mackrory <ma...@gmail.com>.
> On Sept. 4, 2013, 8:57 p.m., Mark Grover wrote:
> > bigtop-packages/src/rpm/oozie/SPECS/oozie.spec, line 173
> > <https://reviews.apache.org/r/13943/diff/1/?file=347476#file347476line173>
> >
> > Do we need "-r" here?
Probably. Will add...
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13943/#review25902
-----------------------------------------------------------
On Sept. 3, 2013, 1:46 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13943/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2013, 1:46 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-939
> https://issues.apache.org/jira/browse/BIGTOP-939
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA for details...
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/hadoop/hadoop-httpfs.svc de4d6d2
> bigtop-packages/src/common/hadoop/httpfs.default e48e608
> bigtop-packages/src/common/hadoop/install_hadoop.sh 08ddb52
> bigtop-packages/src/common/oozie/install_oozie.sh c27dd64
> bigtop-packages/src/common/oozie/oozie-env.sh dd051f7
> bigtop-packages/src/common/oozie/oozie.init 4600841
> bigtop-packages/src/common/solr/install_solr.sh 3e27c3b
> bigtop-packages/src/common/solr/solr-server.init.debian 5b8b862
> bigtop-packages/src/common/sqoop/install_sqoop.sh df4f489
> bigtop-packages/src/common/sqoop/sqoop-server.sh b1de301
> bigtop-packages/src/common/sqoop/sqoop.default cdec81c
> bigtop-packages/src/deb/hadoop/hadoop-httpfs.install fe1a462
> bigtop-packages/src/deb/oozie/oozie.postinst 23decab
> bigtop-packages/src/deb/oozie/rules bb1e6c0
> bigtop-packages/src/deb/sqoop/sqoop.install 0386c7a
> bigtop-packages/src/rpm/hadoop/SPECS/hadoop.spec acfc2fa
> bigtop-packages/src/rpm/oozie/SPECS/oozie.spec 4bbc212
> bigtop-packages/src/rpm/solr/SOURCES/solr-server.init 6d1a035
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 5f4447b
>
> Diff: https://reviews.apache.org/r/13943/diff/
>
>
> Testing
> -------
>
> See JIRA for details...
>
>
> Thanks,
>
> Sean Mackrory
>
>
Re: Review Request 13943: BIGTOP-939: Moving Tomcat configuration under /etc,
deploying to /var at run-time.
Posted by Mark Grover <gr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13943/#review25902
-----------------------------------------------------------
bigtop-packages/src/rpm/oozie/SPECS/oozie.spec
<https://reviews.apache.org/r/13943/#comment50537>
While I can understand the choice of .default here in the directory name, it seems a little confusing. Interpret this comment as a nitpick, since choosing a name hasn't been my forté but how about something like ".non-secure" or ".non-ssl"? That would make it sound less like a defaults file.
bigtop-packages/src/rpm/oozie/SPECS/oozie.spec
<https://reviews.apache.org/r/13943/#comment50536>
Do we need "-r" here?
- Mark Grover
On Sept. 3, 2013, 1:46 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13943/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2013, 1:46 p.m.)
>
>
> Review request for bigtop.
>
>
> Bugs: BIGTOP-939
> https://issues.apache.org/jira/browse/BIGTOP-939
>
>
> Repository: bigtop
>
>
> Description
> -------
>
> See JIRA for details...
>
>
> Diffs
> -----
>
> bigtop-packages/src/common/hadoop/hadoop-httpfs.svc de4d6d2
> bigtop-packages/src/common/hadoop/httpfs.default e48e608
> bigtop-packages/src/common/hadoop/install_hadoop.sh 08ddb52
> bigtop-packages/src/common/oozie/install_oozie.sh c27dd64
> bigtop-packages/src/common/oozie/oozie-env.sh dd051f7
> bigtop-packages/src/common/oozie/oozie.init 4600841
> bigtop-packages/src/common/solr/install_solr.sh 3e27c3b
> bigtop-packages/src/common/solr/solr-server.init.debian 5b8b862
> bigtop-packages/src/common/sqoop/install_sqoop.sh df4f489
> bigtop-packages/src/common/sqoop/sqoop-server.sh b1de301
> bigtop-packages/src/common/sqoop/sqoop.default cdec81c
> bigtop-packages/src/deb/hadoop/hadoop-httpfs.install fe1a462
> bigtop-packages/src/deb/oozie/oozie.postinst 23decab
> bigtop-packages/src/deb/oozie/rules bb1e6c0
> bigtop-packages/src/deb/sqoop/sqoop.install 0386c7a
> bigtop-packages/src/rpm/hadoop/SPECS/hadoop.spec acfc2fa
> bigtop-packages/src/rpm/oozie/SPECS/oozie.spec 4bbc212
> bigtop-packages/src/rpm/solr/SOURCES/solr-server.init 6d1a035
> bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 5f4447b
>
> Diff: https://reviews.apache.org/r/13943/diff/
>
>
> Testing
> -------
>
> See JIRA for details...
>
>
> Thanks,
>
> Sean Mackrory
>
>