You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@answer.apache.org by "EkkoKo (via GitHub)" <gi...@apache.org> on 2024/07/23 10:58:05 UTC
[PR] conf.go: Added an option for environment variables override [incubator-answer]
EkkoKo opened a new pull request, #1042:
URL: https://github.com/apache/incubator-answer/pull/1042
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Added an option for environment variables override [incubator-answer]
Posted by "EkkoKo (via GitHub)" <gi...@apache.org>.
EkkoKo commented on code in PR #1042:
URL: https://github.com/apache/incubator-answer/pull/1042#discussion_r1689180486
##########
internal/base/conf/conf.go:
##########
@@ -45,6 +46,21 @@ type AllConfig struct {
UI *server.UI `json:"ui" mapstructure:"ui" yaml:"ui"`
}
+type EnvConfigOverrides struct {
+ SWAGGER_HOST string
+ SWAGGER_ADDRESS_PORT string
+
+ SITE_ADDR string
Review Comment:
Changed it to camel case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Added an option for environment variables override [incubator-answer]
Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on code in PR #1042:
URL: https://github.com/apache/incubator-answer/pull/1042#discussion_r1689025888
##########
internal/base/conf/conf.go:
##########
@@ -45,6 +46,21 @@ type AllConfig struct {
UI *server.UI `json:"ui" mapstructure:"ui" yaml:"ui"`
}
+type EnvConfigOverrides struct {
+ SWAGGER_HOST string
+ SWAGGER_ADDRESS_PORT string
+
+ SITE_ADDR string
Review Comment:
<img width="690" alt="image" src="https://github.com/user-attachments/assets/65ea9c84-ee55-4672-b11a-49d00aab906f">
In Golang, use camel case instead of snake case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Added an option for environment variables override [incubator-answer]
Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars merged PR #1042:
URL: https://github.com/apache/incubator-answer/pull/1042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org