You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "DanielWang2035 (via GitHub)" <gi...@apache.org> on 2023/07/14 06:09:28 UTC
[GitHub] [iotdb] DanielWang2035 opened a new pull request, #10554: Pipe: Add knob for tablet size
DanielWang2035 opened a new pull request, #10554:
URL: https://github.com/apache/iotdb/pull/10554
Currently, tablets in pipe transfer are created with default rowSize. If data fransfer load is high, there will be too many thrift requests of tablet transfer. So we can add a knob to specify rowSize of pipe tablets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] DanielWang2035 commented on a diff in pull request #10554: Pipe: Add a configuration parameter to control the number of rows of the tablet used within the pipe module
Posted by "DanielWang2035 (via GitHub)" <gi...@apache.org>.
DanielWang2035 commented on code in PR #10554:
URL: https://github.com/apache/iotdb/pull/10554#discussion_r1264872639
##########
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -972,6 +972,9 @@ cluster_name=defaultCluster
# Noted that: this should be less than or equals to realtimeExtractorPendingQueueCapacity
# pipe_extractor_pending_queue_tablet_limit=64
+# The row size of tablets created in the extractor stage.
+# pipe_extractor_tablet_row_size=65536
Review Comment:
changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on pull request #10554: Pipe: Add a configuration parameter to control the number of rows of the tablet used within the pipe module
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu commented on PR #10554:
URL: https://github.com/apache/iotdb/pull/10554#issuecomment-1637677547
Please cp this commit to rel/1.2, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #10554: Pipe: Add a configuration parameter to control the number of rows of the tablet used within the pipe module
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #10554:
URL: https://github.com/apache/iotdb/pull/10554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a diff in pull request #10554: Pipe: Add knob for tablet size
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu commented on code in PR #10554:
URL: https://github.com/apache/iotdb/pull/10554#discussion_r1264805574
##########
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -972,6 +972,9 @@ cluster_name=defaultCluster
# Noted that: this should be less than or equals to realtimeExtractorPendingQueueCapacity
# pipe_extractor_pending_queue_tablet_limit=64
+# The row size of tablets created in the extractor stage.
+# pipe_extractor_tablet_row_size=65536
Review Comment:
```suggestion
# pipe_datastructure_tablet_row_size=65535
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org