You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Zhihong Yu (Created) (JIRA)" <ji...@apache.org> on 2012/03/07 17:06:57 UTC
[jira] [Created] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Support GetData and GetChildren in Multi
----------------------------------------
Key: ZOOKEEPER-1407
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
Project: ZooKeeper
Issue Type: Improvement
Reporter: Zhihong Yu
There is use case where GetData and GetChildren would participate in Multi.
We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated ZOOKEEPER-1407:
----------------------------------
Attachment: (was: 1407.txt)
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Attachments: 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242612#comment-13242612 ]
Hadoop QA commented on ZOOKEEPER-1407:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520633/1407-v5.txt
against trunk revision 1307191.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1021//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1021//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1021//console
This message is automatically generated.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated ZOOKEEPER-1407:
----------------------------------
Attachment: 1407.txt
Initial attempt.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Attachments: 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Camille Fournier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233631#comment-13233631 ]
Camille Fournier commented on ZOOKEEPER-1407:
---------------------------------------------
Zhihong, it's good if you change the state to "Patch Available" when you've got something for us to look at. We generally look at the patch available queue to determine what we need to review, etc. It will also trigger the automated build check. I've set this one to patch available.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1407:
---------------------------------------
Assignee: Zhihong Yu
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Assignee: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated ZOOKEEPER-1407:
----------------------------------
Attachment: 1407-v5.txt
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234000#comment-13234000 ]
Zhihong Yu commented on ZOOKEEPER-1407:
---------------------------------------
I see the following in build output:
{code}
[exec] [javac] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/java/main/org/apache/zookeeper/Op.java:293: org.apache.zookeeper.Op.GetChildren is not abstract and does not override abstract method withChroot(java.lang.String) in org.apache.zookeeper.Op
[exec] [javac] public static class GetChildren extends Op {
{code}
Looking at other classes (such as Delete) in Op.java, I don't see them having withChroot() method.
I searched codebase and didn't find where withChroot() is defined.
For the following:
{code}
[exec] [javac] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java:758: cannot find symbol
[exec] [javac] symbol : variable debug
[exec] [javac] location: class org.apache.zookeeper.server.DataTree
[exec] [javac] debug = "Get children transaction for "
{code}
debug is defined at line 732, outside the try loop.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234432#comment-13234432 ]
Hadoop QA commented on ZOOKEEPER-1407:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519238/1407-v3.txt
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1003//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1003//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1003//console
This message is automatically generated.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407-v3.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated ZOOKEEPER-1407:
----------------------------------
Attachment: 1407-v4.txt
When adding ops.add(Op.getData()) call to MultiTransactionTest.java, I found a lot of places where getData was handled in patch v3.
I am not sure about the following code in MultiResponse.serialize():
{code}
Stat stat = new Stat();
new GetDataResponse(gdr.getData(), stat).serialize(archive, tag);
break;
{code}
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Marshall McMullen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225913#comment-13225913 ]
Marshall McMullen commented on ZOOKEEPER-1407:
----------------------------------------------
I see the new updated patch in the reviewboard but should upload it to this case as well.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Attachments: 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated ZOOKEEPER-1407:
----------------------------------
Attachment: 1407-v3.txt
Rebased patch based on current trunk.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407-v3.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Marshall McMullen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225912#comment-13225912 ]
Marshall McMullen commented on ZOOKEEPER-1407:
----------------------------------------------
I don't see a new version of the patch to cover GetChildren... did you forget to upload new patch?
I agree hashCode could be improved.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Attachments: 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225728#comment-13225728 ]
Zhihong Yu commented on ZOOKEEPER-1407:
---------------------------------------
I see SetDataTxn used in a private method, proposeSetData(), of Zab1_0Test.
w.r.t. writing test for GetData, I would seek some advice.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Attachments: 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225717#comment-13225717 ]
Zhihong Yu commented on ZOOKEEPER-1407:
---------------------------------------
https://reviews.apache.org/r/4264/ has been created.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Attachments: 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Marshall McMullen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234148#comment-13234148 ]
Marshall McMullen commented on ZOOKEEPER-1407:
----------------------------------------------
This is probably related to changes that just went in for https://issues.apache.org/jira/browse/ZOOKEEPER-1344
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242049#comment-13242049 ]
Hadoop QA commented on ZOOKEEPER-1407:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520560/1407-v4.txt
against trunk revision 1307191.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 6 javac compiler warnings (more than the trunk's current 5 warnings).
-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1020//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1020//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1020//console
This message is automatically generated.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated ZOOKEEPER-1407:
----------------------------------
Attachment: 1407.txt
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Attachments: 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225859#comment-13225859 ]
Zhihong Yu commented on ZOOKEEPER-1407:
---------------------------------------
Uploaded new version of patch which covers GetChildren.
I think we should produce better hash code compared to what we have now:
{code}
public int hashCode() {
return getType() + getPath().hashCode() + Arrays.hashCode(data) + version;
}
{code}
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Attachments: 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233717#comment-13233717 ]
Hadoop QA commented on ZOOKEEPER-1407:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517718/1407-v2.txt
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1002//testReport/
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1002//console
This message is automatically generated.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated ZOOKEEPER-1407:
----------------------------------
Attachment: 1407-v2.txt
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Attachments: 1407-v2.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242578#comment-13242578 ]
Zhihong Yu commented on ZOOKEEPER-1407:
---------------------------------------
With 1407-v5.txt, I see the following in test output:
{code}
2012-03-30 10:31:56,090 [myid:] - WARN [main-SendThread(localhost:11221):ClientCnxn$SendThread@1061] - Session 0x13664a9dee20001 for server localhost/127.0.0.1:11221, unexpected error, closing socket connection and attempting reconnect
java.io.IOException: Invalid type 256 in MultiResponse
at org.apache.zookeeper.MultiResponse.deserialize(MultiResponse.java:135)
at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:812)
at org.apache.zookeeper.ClientCnxnSocketNIO.doIO(ClientCnxnSocketNIO.java:94)
at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:287)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1039)
{code}
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233634#comment-13233634 ]
Zhihong Yu commented on ZOOKEEPER-1407:
---------------------------------------
Thanks Camille.
Without proper unit tests Ted Dunning requested, I didn't regard the patch to be available for full-scale review.
Pardon my laziness.
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren
in Multi
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242041#comment-13242041 ]
Zhihong Yu commented on ZOOKEEPER-1407:
---------------------------------------
Found a typo above: should read "where getData wasn't handled in patch v3"
> Support GetData and GetChildren in Multi
> ----------------------------------------
>
> Key: ZOOKEEPER-1407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 3.5.0
>
> Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407.txt
>
>
> There is use case where GetData and GetChildren would participate in Multi.
> We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira