You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/09 03:16:04 UTC
[GitHub] [solr] madrob opened a new pull request #619: SOLR-11749 Several test changes
madrob opened a new pull request #619:
URL: https://github.com/apache/solr/pull/619
https://issues.apache.org/jira/browse/SOLR-11749
Still some rough edges, it's all macOS only for now, but I think it's a good start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija edited a comment on pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
gerlowskija edited a comment on pull request #619:
URL: https://github.com/apache/solr/pull/619#issuecomment-1046114680
LGTM - tests passed on my Macbook and on an Ubuntu 20.04 machine I have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #619:
URL: https://github.com/apache/solr/pull/619#issuecomment-1055822700
This does likely warrant a changes.txt entry. (And you might want to add a github action to run the tests when only that directory has been changed, we can expand it later)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #619:
URL: https://github.com/apache/solr/pull/619#issuecomment-1055823754
re: CHANGES.txt
@janhoy - 9.0 or 9.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #619:
URL: https://github.com/apache/solr/pull/619#issuecomment-1055862357
I vote 9.1 probably, though if it passes, it doesn't really matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a change in pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #619:
URL: https://github.com/apache/solr/pull/619#discussion_r806122005
##########
File path: solr/packaging/build.gradle
##########
@@ -160,3 +165,55 @@ distTar {
distZip.enabled = false
assemble.dependsOn installDist
+
+
+// We use Node to install BATS
+node {
+ // The Node.js project directory location
+ // This is where the package.json file and node_modules directory are located
+ // By default it is at the root of the current project
+ nodeProjectDir = project.ext.nodeProjectDir
+}
+
+task downloadBats(type: NpmTask) {
+ group = 'Build Dependency Download'
+ args = ["install", "bats",
+ "ztombol/bats-support",
+ "ztombol/bats-assert",
+ ]
+
+ inputs.files("${project.ext.nodeProjectDir}/package.json")
+ outputs.dir("${project.ext.nodeProjectDir}/node_modules/bats")
+ outputs.dir("${project.ext.nodeProjectDir}/node_modules/bats-support")
+ outputs.dir("${project.ext.nodeProjectDir}/node_modules/bats-assert")
+}
+
+task bats(type: Exec) {
+ dependsOn installDist
+ dependsOn downloadBats
+
+ def testOutput = "$buildDir/bats-output"
Review comment:
Can we call this `integration-test-output`, and rename the task to `integrationTests` or something like that. To me, most people won't know what Bats is.
##########
File path: solr/docker/tests/cases/initdb/test.sh
##########
@@ -41,7 +41,7 @@ if [[ "$data" != /var/solr/initdb-was-here ]]; then
echo "Test $TEST_DIR $tag failed; script did not run"
exit 1
fi
-data=$(docker exec --user=solr "$container_name" ls /var/solr/should-not-be; true)
+data=$(docker exec --user=solr "$container_name" ls /var/solr/should-not-be ; true)
Review comment:
?
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -175,15 +173,6 @@ dependencies {
// We use Node to install and run Antora
node {
- download = true
- version = "16.13.2" // LTS
-
- // The directory where Node.js is unpacked (when download is true)
- workDir = file("${project.ext.rootNodeDir}/nodejs")
-
- // The directory where npm is installed (when a specific version is defined)
- npmWorkDir = file("${project.ext.rootNodeDir}/npm")
-
// The directory where yarn is installed (when a Yarn task is used)
Review comment:
Shouldn't need to keep the yarn directory either.
##########
File path: gradle/node.gradle
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: "com.github.node-gradle.node"
+
+ext {
+ rootNodeDir = "$rootDir/.gradle/node"
+}
+
+node {
Review comment:
Instead of sourcing, can you do a project configure, like is done throughout other files in this directory?
Example: https://github.com/apache/solr/blob/main/gradle/solr/packaging.gradle#L39
##########
File path: solr/packaging/test/bats_helper.bash
##########
@@ -0,0 +1,65 @@
+#!/usr/bin/env bats
Review comment:
is this a bash or bats file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #619:
URL: https://github.com/apache/solr/pull/619#discussion_r819749140
##########
File path: solr/bin/solr
##########
@@ -99,14 +102,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then
. "$SOLR_INCLUDE"
fi
-if [ -z "$SOLR_PID_DIR" ]; then
- SOLR_PID_DIR="$SOLR_TIP/bin"
-fi
+# if pid dir is unset, deafult to $solr_tip/bin
+: ${SOLR_PID_DIR:=$SOLR_TIP/bin}
-if [ -n "$SOLR_JAVA_HOME" ]; then
+if [ -n "${SOLR_JAVA_HOME:-}" ]; then
JAVA="$SOLR_JAVA_HOME/bin/java"
JSTACK="$SOLR_JAVA_HOME/bin/jstack"
-elif [ -n "$JAVA_HOME" ]; then
+elif [ -v JAVA_HOME ]; then
Review comment:
This gives `[: -v: unary operator expected` for older versions of bash.
Could `-n "${JAVA_HOME:-}"` be used instead, consistent with the `SOLR_JAVA_HOME` check a few lines above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a change in pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #619:
URL: https://github.com/apache/solr/pull/619#discussion_r806122005
##########
File path: solr/packaging/build.gradle
##########
@@ -160,3 +165,55 @@ distTar {
distZip.enabled = false
assemble.dependsOn installDist
+
+
+// We use Node to install BATS
+node {
+ // The Node.js project directory location
+ // This is where the package.json file and node_modules directory are located
+ // By default it is at the root of the current project
+ nodeProjectDir = project.ext.nodeProjectDir
+}
+
+task downloadBats(type: NpmTask) {
+ group = 'Build Dependency Download'
+ args = ["install", "bats",
+ "ztombol/bats-support",
+ "ztombol/bats-assert",
+ ]
+
+ inputs.files("${project.ext.nodeProjectDir}/package.json")
+ outputs.dir("${project.ext.nodeProjectDir}/node_modules/bats")
+ outputs.dir("${project.ext.nodeProjectDir}/node_modules/bats-support")
+ outputs.dir("${project.ext.nodeProjectDir}/node_modules/bats-assert")
+}
+
+task bats(type: Exec) {
+ dependsOn installDist
+ dependsOn downloadBats
+
+ def testOutput = "$buildDir/bats-output"
Review comment:
Can we call this `integration-test-output`, and rename the task to `integrationTests` or something like that. To me, most people won't know what Bats is.
##########
File path: solr/docker/tests/cases/initdb/test.sh
##########
@@ -41,7 +41,7 @@ if [[ "$data" != /var/solr/initdb-was-here ]]; then
echo "Test $TEST_DIR $tag failed; script did not run"
exit 1
fi
-data=$(docker exec --user=solr "$container_name" ls /var/solr/should-not-be; true)
+data=$(docker exec --user=solr "$container_name" ls /var/solr/should-not-be ; true)
Review comment:
?
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -175,15 +173,6 @@ dependencies {
// We use Node to install and run Antora
node {
- download = true
- version = "16.13.2" // LTS
-
- // The directory where Node.js is unpacked (when download is true)
- workDir = file("${project.ext.rootNodeDir}/nodejs")
-
- // The directory where npm is installed (when a specific version is defined)
- npmWorkDir = file("${project.ext.rootNodeDir}/npm")
-
// The directory where yarn is installed (when a Yarn task is used)
Review comment:
Shouldn't need to keep the yarn directory either.
##########
File path: gradle/node.gradle
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: "com.github.node-gradle.node"
+
+ext {
+ rootNodeDir = "$rootDir/.gradle/node"
+}
+
+node {
Review comment:
Instead of sourcing, can you do a project configure, like is done throughout other files in this directory?
Example: https://github.com/apache/solr/blob/main/gradle/solr/packaging.gradle#L39
##########
File path: solr/packaging/test/bats_helper.bash
##########
@@ -0,0 +1,65 @@
+#!/usr/bin/env bats
Review comment:
is this a bash or bats file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on a change in pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on a change in pull request #619:
URL: https://github.com/apache/solr/pull/619#discussion_r810480771
##########
File path: solr/packaging/test/test_start_solr.bats
##########
@@ -14,12 +15,19 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-function delete_all_collections() {
- local collection_list="$(bin/solr zk ls /collections -z localhost:9983)"
- for collection in $collection_list;
- do
- if [[ -n $collection ]]; then
- bin/solr delete -c $collection
- fi
- done
+load bats_helper
+
+setup() {
+ common_setup
+}
+
+teardown() {
+ solr stop -all >/dev/null 2>&1
+}
+
+@test "SOLR11740 check f" {
+ run -0 solr start
+ run -0 solr start -p 7574
+ run bash -c 'solr stop -all 2>&1'
+ refute_output --partial 'forecfully killing'
Review comment:
[Q] Is 'forecfully' a typo here, or a part of the test?
##########
File path: solr/packaging/test/README.md
##########
@@ -0,0 +1,57 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+# bin/solr Tests
+
+This directory contains tests for the `bin/solr` command-line scripts.
+
+All tests in this project use the [BATS](https://bats-core.readthedocs.io/en/stable/index.html) framework.
+
+## Running Tests
+
+Tests can be run via `./gradlew bats`.
Review comment:
[-1] Should the task name here be `integrationTests`? That's the task that works for me from the CLI, and the one that I see in `solr/packaging/build.gradle`
##########
File path: solr/packaging/test/README.md
##########
@@ -0,0 +1,57 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+# bin/solr Tests
+
+This directory contains tests for the `bin/solr` command-line scripts.
+
+All tests in this project use the [BATS](https://bats-core.readthedocs.io/en/stable/index.html) framework.
+
+## Running Tests
+
+Tests can be run via `./gradlew bats`.
+ This will download the necessary BATS libraries to your `.gradle` directory,
+ assemble the binary distribution, and run the full test suite.
+
+Individual test files can be run by specifying the `-P bats.tests=[test_file.bats]` property.
+
+## Writing Tests
+
+Our tests should all `load bats_helper` which provides a `common_setup` function that test files can
+call from their own `setup()` function.
+
+Test are defined as `@test "description of the test" { ... }`
+ with statements in the function body. Test names can include
+ letters, number, and spaces. They cannot include special
+ characters like dashes or underscores, so JIRA issue numbers
+ and command line flags are not valid test names. For more detail
+ about BATS features, please consult
+ special features of BATS, please consult
+
+Some tests will start clusters or create collections,
+ please take care to delete any resources that you create.
+ They will not be cleaned for you automatically.
+
+It is recommended that you install and run `shellcheck` to verify your test scripts and catch common mistakes before committing your changes.
Review comment:
Neat!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #619:
URL: https://github.com/apache/solr/pull/619#issuecomment-1055993931
Sure, but if the test itself is unstable, not the code being tested.. we’ll soon know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob merged pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #619:
URL: https://github.com/apache/solr/pull/619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #619:
URL: https://github.com/apache/solr/pull/619#discussion_r819866750
##########
File path: solr/bin/solr
##########
@@ -99,14 +102,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then
. "$SOLR_INCLUDE"
fi
-if [ -z "$SOLR_PID_DIR" ]; then
- SOLR_PID_DIR="$SOLR_TIP/bin"
-fi
+# if pid dir is unset, deafult to $solr_tip/bin
+: ${SOLR_PID_DIR:=$SOLR_TIP/bin}
-if [ -n "$SOLR_JAVA_HOME" ]; then
+if [ -n "${SOLR_JAVA_HOME:-}" ]; then
JAVA="$SOLR_JAVA_HOME/bin/java"
JSTACK="$SOLR_JAVA_HOME/bin/jstack"
-elif [ -n "$JAVA_HOME" ]; then
+elif [ -v JAVA_HOME ]; then
Review comment:
Done in c3b56ab, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #619:
URL: https://github.com/apache/solr/pull/619#discussion_r804135339
##########
File path: gradle/node.gradle
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: "com.github.node-gradle.node"
+
+ext {
+ rootNodeDir = "$rootDir/.gradle/node"
+}
+
+node {
Review comment:
realistically, we need to figure out how to only apply this to projects that have an NpmTask, but I'm not sure if that causes a chicken and egg problem? For now, I have the two projects that care source this file directly.
##########
File path: solr/packaging/build.gradle
##########
@@ -160,3 +165,55 @@ distTar {
distZip.enabled = false
assemble.dependsOn installDist
+
+
+// We use Node to install BATS
+node {
+ // The Node.js project directory location
+ // This is where the package.json file and node_modules directory are located
+ // By default it is at the root of the current project
+ nodeProjectDir = project.ext.nodeProjectDir
+}
+
+task downloadBats(type: NpmTask) {
+ group = 'Build Dependency Download'
+ args = ["install", "bats",
+ "ztombol/bats-support",
+ "ztombol/bats-assert",
+ ]
+
+ inputs.files("${project.ext.nodeProjectDir}/package.json")
+ outputs.dir("${project.ext.nodeProjectDir}/node_modules/bats")
+ outputs.dir("${project.ext.nodeProjectDir}/node_modules/bats-support")
+ outputs.dir("${project.ext.nodeProjectDir}/node_modules/bats-assert")
+}
+
+task bats(type: Exec) {
+ dependsOn installDist
+ dependsOn downloadBats
+
+ def testOutput = "$buildDir/bats-output"
+ def solrHome = "$testOutput/solr-home-" + Instant.now().toEpochMilli()
Review comment:
I don't know if this is a good or bad practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on pull request #619:
URL: https://github.com/apache/solr/pull/619#issuecomment-1046114680
LGTM - it passed on my Macbook and on an Ubuntu 20.04 machine I have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #619:
URL: https://github.com/apache/solr/pull/619#issuecomment-1055923407
Nice work. I’m ok with 9.0, but be prepared to fix failing tests, or to revert if it becomes unstable for some other reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #619: SOLR-11749 Several test changes
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #619:
URL: https://github.com/apache/solr/pull/619#issuecomment-1055945207
> be prepared to fix failing tests
Part of the problem is that we weren't running any of these tests before!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org