[jira] [Resolved] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

["Adrien Grand (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrien Grand resolved LUCENE-8805.
----------------------------------
       Resolution: Fixed
    Fix Version/s: master (9.0)

Thanks [~danmuzi], I just merged your change to master. I decided to not backport to 8.x since it's breaking but I could easily be convinced to if someone else has a different opinion. Thanks again for contributing!

> Parameter changes for stringField() in StoredFieldVisitor
> ---------------------------------------------------------
>
>                 Key: LUCENE-8805
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8805
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Namgyu Kim
>            Priority: Major
>             Fix For: master (9.0)
>
>         Attachments: LUCENE-8805.patch, LUCENE-8805.patch, LUCENE-8805.patch
>
>
> I wrote this patch after seeing the comments left by [~mikemccand] when SortingStoredFieldsConsumer class was first created.
> {code:java}
> @Override
> public void binaryField(FieldInfo fieldInfo, byte[] value) throws IOException {
>   ...
>   // TODO: can we avoid new BR here?
>   ...
> }
> @Override
> public void stringField(FieldInfo fieldInfo, byte[] value) throws IOException {
>   ...
>   // TODO: can we avoid new String here?
>   ...
> }
> {code}
> I changed two things.
>  -1) change binaryField() parameters from byte[] to BytesRef.-
>  2) change stringField() parameters from byte[] to String.
> I also changed the related contents while doing the work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org