You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/12 16:39:03 UTC

[GitHub] [incubator-dolphinscheduler] khadgarmage opened a new issue #1461: [CI/CD]Add checkstyle check

khadgarmage opened a new issue #1461: [CI/CD]Add checkstyle check
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1461
 
 
   follow the root issue: #1460 
   Steps:
   1、chose the checkstyle guidline,  google or alibaba
   2、modify files which not satisfy the guildline，and pay attention not to submit too much files each time in a pr, it is better not to exceed 10, which is convenient for review, and can be split into multiple pr to submit, and the pr which you submit should follow this issue (e.g. #xxx).
   3、Add to github action to execute this check in ".github" directory, and we must ensure that CI / CD is successfully rebuilt, you can put the files which you modified into the maven pom.xml whitelist, to ensure the rebuilt successfully.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services