You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by ta...@apache.org on 2005/06/28 07:40:13 UTC
svn commit: r202133 - in
/portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed:
services/title/DynamicTitleServiceImpl.java
velocity/JetspeedPowerToolImpl.java
Author: taylor
Date: Mon Jun 27 22:40:09 2005
New Revision: 202133
URL: http://svn.apache.org/viewcvs?rev=202133&view=rev
Log:
optimize setTitle to only set the title for the current request per basic interpretation of spec
Modified:
portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleServiceImpl.java
portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/velocity/JetspeedPowerToolImpl.java
Modified: portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleServiceImpl.java
URL: http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleServiceImpl.java?rev=202133&r1=202132&r2=202133&view=diff
==============================================================================
--- portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleServiceImpl.java (original)
+++ portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleServiceImpl.java Mon Jun 27 22:40:09 2005
@@ -22,36 +22,24 @@
import org.apache.jetspeed.PortalReservedParameters;
import org.apache.jetspeed.request.RequestContext;
+import org.apache.pluto.om.common.ObjectID;
import org.apache.pluto.om.common.Preference;
import org.apache.pluto.om.entity.PortletEntity;
import org.apache.pluto.om.window.PortletWindow;
import org.apache.pluto.services.title.DynamicTitleService;
+import com.sun.corba.se.internal.ior.ObjectId;
+
public class DynamicTitleServiceImpl implements DynamicTitleService
{
public void setDynamicTitle(PortletWindow window,
HttpServletRequest request, String titleArg)
{
- String title = getTitleFromPreference(window, request);
-
- if (title == null || title.length() < 0)
- {
- if (titleArg == null || titleArg.length() == 0)
- {
- title = getTitleFromPortletDefinition(window, request);
- }
- else
- {
- title = titleArg;
- }
-
- }
-
+ ObjectID id = window.getPortletEntity().getId();
request.setAttribute(
PortalReservedParameters.OVERRIDE_PORTLET_TITLE_ATTR
- + "::window.id::" + window.getId(), title);
-
+ + "::entity.id::" + id.toString(), titleArg);
}
protected final String getTitleFromPortletDefinition(PortletWindow window,
Modified: portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/velocity/JetspeedPowerToolImpl.java
URL: http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/velocity/JetspeedPowerToolImpl.java?rev=202133&r1=202132&r2=202133&view=diff
==============================================================================
--- portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/velocity/JetspeedPowerToolImpl.java (original)
+++ portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/velocity/JetspeedPowerToolImpl.java Mon Jun 27 22:40:09 2005
@@ -821,7 +821,14 @@
{
String title = null;
- if (f != null)
+ String override = (String)getRequestContext().getRequest().getAttribute(
+ PortalReservedParameters.OVERRIDE_PORTLET_TITLE_ATTR
+ + "::entity.id::" + entity.getId());
+ if (override != null)
+ {
+ title = override;
+ }
+ else if (f != null)
{
title = f.getTitle();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
Re: svn commit: r202133 - in /portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed:
services/title/DynamicTitleServiceImpl.java velocity/JetspeedPowerToolImpl.java
Posted by David Sean Taylor <da...@bluesunrise.com>.
James Liao wrote:
> Hi all,
> I think the optimize for DynamicTitleServiceImpl have a problem.
> If a portlet's Resources doesn't contain javax.portlet.title property,
> the portlet will lost its title. For example, almost all the
> Administrative portlet have this problem.
>
> I have do a little bit investigated on it. I found the cause of this
> is in LanguageImpl and LanguageSetImpl. The LanguageImpl's method:
> setTitle(), setShortTitle() and setKeywords() will not set the value
> into DefaultsResourceBundle object's defaultValues Map.
>
> So can not use the LanguageSetImpl's createLanguage method like this:
>
> createLanguage(lang.getLocale(), loadResourceBundle(lang.getLocale()),"","","");
> language.setTitle(lang.getTitle());
> language.setShortTitle(lang.getShortTitle());
> language.setKeywords(StringUtils.join(lang.getKeywords(), ","));
>
> Should be used like this:
> createLanguage(lang.getLocale(), loadResourceBundle(lang.getLocale()),
> lang.getTitle(), lang.getShortTitle(),
> StringUtils.join(lang.getKeywords(), ","));
>
> If it is necessary, I could raise a bug for this and provide a patch.
>
Thanks (again) James
I'll apply this patch and see how it works here today
Regards,
--
David Sean Taylor
Bluesunrise Software
david@bluesunrise.com
[office] +01 707 773-4646
[mobile] +01 707 529 9194
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
Re: svn commit: r202133 - in /portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed: services/title/DynamicTitleServiceImpl.java velocity/JetspeedPowerToolImpl.java
Posted by James Liao <ji...@gmail.com>.
Hi all,
I think the optimize for DynamicTitleServiceImpl have a problem.
If a portlet's Resources doesn't contain javax.portlet.title property,
the portlet will lost its title. For example, almost all the
Administrative portlet have this problem.
I have do a little bit investigated on it. I found the cause of this
is in LanguageImpl and LanguageSetImpl. The LanguageImpl's method:
setTitle(), setShortTitle() and setKeywords() will not set the value
into DefaultsResourceBundle object's defaultValues Map.
So can not use the LanguageSetImpl's createLanguage method like this:
createLanguage(lang.getLocale(), loadResourceBundle(lang.getLocale()),"","","");
language.setTitle(lang.getTitle());
language.setShortTitle(lang.getShortTitle());
language.setKeywords(StringUtils.join(lang.getKeywords(), ","));
Should be used like this:
createLanguage(lang.getLocale(), loadResourceBundle(lang.getLocale()),
lang.getTitle(), lang.getShortTitle(),
StringUtils.join(lang.getKeywords(), ","));
If it is necessary, I could raise a bug for this and provide a patch.
-James Liao
On 6/28/05, Wolfgang Miller-Reichling <wo...@webde-ag.de> wrote:
> taylor@apache.org wrote:
> > --- portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleServiceImpl.java (original)
> > +++ portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleServiceImpl.java Mon Jun 27 22:40:09 2005
> >
> > +import com.sun.corba.se.internal.ior.ObjectId;
> > +
> > public class DynamicTitleServiceImpl implements DynamicTitleService
>
> The above import breaks the build, I guess it slipped in through an
> eclipse quick fix. Deleting it fixes the build.
>
> Wolfgang
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
Re: svn commit: r202133 - in /portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed: services/title/DynamicTitleServiceImpl.java velocity/JetspeedPowerToolImpl.java
Posted by Wolfgang Miller-Reichling <wo...@webde-ag.de>.
taylor@apache.org wrote:
> --- portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleServiceImpl.java (original)
> +++ portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleServiceImpl.java Mon Jun 27 22:40:09 2005
>
> +import com.sun.corba.se.internal.ior.ObjectId;
> +
> public class DynamicTitleServiceImpl implements DynamicTitleService
The above import breaks the build, I guess it slipped in through an
eclipse quick fix. Deleting it fixes the build.
Wolfgang
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org