[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6483: Guard against multiple consuming segments for same partition

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #6483:
URL: https://github.com/apache/incubator-pinot/pull/6483#discussion_r563999016



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -793,6 +793,27 @@ void updateInstanceStatesForNewConsumingSegment(Map<String, Map<String, String>>
       LOGGER.info("Updating segment: {} to ONLINE state", committingSegmentName);
     }
 
+    // There used to be a race condition in pinot (caused by heavy GC on the controller during segment commit)

Review comment:
       Last time this happened, it was caused by gc on the controller, and the same controller waking up to complete the operation it is scheduled to do. 
   I could not dig up the PR since it happened (I think) when the source code was under com.linkedin domain, but it was fixed by @jackjlli  by adding a Stat check when we update metadata for the committing segment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org