[jira] [Comment Edited] (LOG4J2-2947) LogBuilder should not have no-op default methods

["Marcono1234 (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296321#comment-17296321 ] 

Marcono1234 edited comment on LOG4J2-2947 at 3/5/21, 8:36 PM:
--------------------------------------------------------------

[~rgoers], it would be good to eventually remove all these empty default implementations in {{LogBuilder}} and other classes and only use abstract methods for the 3.x.x branch. Should I create a separate issue for that?


was (Author: marcono1234):
[~rgoers], it would be good to eventually remove all these default implementations in {{LogBuilder}} and other classes and only use abstract methods for the 3.x.x branch. Should I create a separate issue for that?

> LogBuilder should not have no-op default methods
> ------------------------------------------------
>
>                 Key: LOG4J2-2947
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2947
>             Project: Log4j 2
>          Issue Type: Wish
>            Reporter: Marcono1234
>            Priority: Major
>             Fix For: 2.14.1
>
>
> Currently the methods of the interface {{org.apache.logging.log4j.LogBuilder}} are all default methods which are no-op.
> In my opinion this is not ideal because these no-op implementations should *only* exist for the {{LogBuilder.NOOP}}, or for any methods which are added in the future which not every logger supports.
> With the current situation it is easy to forget implementing one of the {{LogBuilder}} methods.
> If you choose to keep this {{LogBuilder}} behaviour, it would be good to at least document this so implementors of the interface are aware of it. Though this would then create confusion for the end-user because the {{LogBuilder}} returned by {{Logger}} is actually not no-op (which also shows that the {{LogBuilder}} methods should not be no-op by default in the first place).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)