You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rb...@apache.org on 2001/02/07 20:07:46 UTC

cvs commit: httpd-2.0 CHANGES Makefile.in

rbb         01/02/07 11:07:46

  Modified:    .        CHANGES Makefile.in
  Log:
  Install all required header files.  Without these, some modules can not
  be compiled outside the src tree.
  
  Revision  Changes    Path
  1.79      +4 -0      httpd-2.0/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/CHANGES,v
  retrieving revision 1.78
  retrieving revision 1.79
  diff -u -d -b -w -u -r1.78 -r1.79
  --- CHANGES	2001/02/07 17:50:03	1.78
  +++ CHANGES	2001/02/07 19:07:46	1.79
  @@ -1,5 +1,9 @@
   Changes with Apache 2.0b1
   
  +  *) Install all required header files.  Without these, it was not
  +     possible to compile some modules outside of the server.
  +     [Ryan Bloom]
  +
     *) Fix the AliasMatch directive in Apache 2.0.  When we brought a patch
        forward from 1.3 to 2.0, we missed a single line, which broke regex
        aliases.  [Ryan Bloom]
  
  
  
  1.56      +2 -0      httpd-2.0/Makefile.in
  
  Index: Makefile.in
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/Makefile.in,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -d -b -w -u -r1.55 -r1.56
  --- Makefile.in	2001/01/28 20:06:18	1.55
  +++ Makefile.in	2001/02/07 19:07:46	1.56
  @@ -105,12 +105,14 @@
   	@if test -f $(srcdir)/os/$(OS_DIR)/os-inline.c; then \
               cp -p $(srcdir)/os/$(OS_DIR)/os-inline.c $(includedir); \
           fi;
  +	@cp -p $(srcdir)/server/mpm/$(MPM_NAME)/*.h $(includedir)
   	@cp -p $(srcdir)/modules/dav/main/mod_dav.h $(includedir)
   	@cp -p $(srcdir)/modules/filters/mod_include.h $(includedir)
   	@cp -p $(srcdir)/srclib/expat-lite/*.h $(includedir)
   	@cp -p $(srcdir)/srclib/pcre/*.h $(includedir)
   	@cp -p $(srcdir)/srclib/apr/include/*.h $(includedir)
   	@cp -p $(srcdir)/srclib/apr-util/include/*.h $(includedir)
  +	@cp -p $(srcdir)/os/$(OS_DIR)/*.h $(includedir)
   	@chmod 644 $(includedir)/*.h
   
   install-suexec:
  
  
  

Re: cvs commit: httpd-2.0 CHANGES Makefile.in

Posted by rb...@covalent.net.
> >   +++ Makefile.in	2001/02/07 19:07:46	1.56
> >   @@ -105,12 +105,14 @@
> >    	@if test -f $(srcdir)/os/$(OS_DIR)/os-inline.c; then \
> >                cp -p $(srcdir)/os/$(OS_DIR)/os-inline.c $(includedir); \
> >            fi;
> >   +	@cp -p $(srcdir)/server/mpm/$(MPM_NAME)/*.h $(includedir)
> >    	@cp -p $(srcdir)/modules/dav/main/mod_dav.h $(includedir)
> >    	@cp -p $(srcdir)/modules/filters/mod_include.h $(includedir)
> >    	@cp -p $(srcdir)/srclib/expat-lite/*.h $(includedir)
> >    	@cp -p $(srcdir)/srclib/pcre/*.h $(includedir)
> >    	@cp -p $(srcdir)/srclib/apr/include/*.h $(includedir)
> >    	@cp -p $(srcdir)/srclib/apr-util/include/*.h $(includedir)
> >   +	@cp -p $(srcdir)/os/$(OS_DIR)/*.h $(includedir)
> >    	@chmod 644 $(includedir)/*.h
> 
> Woah!
> 
> Who is using MPM headers? Or the OS headers? Aren't all of those supposed to
> be private? e.g. for the MPM, we have a generic, common header that can be
> used as an API.
> 
> And what in the OS directory needs to be exported?

Anytime a file includes the scoreboard, they also need the MPM
definitions, because otherwise they can't find the size of the scoreboard.

The OS headers are used for ap_os_create_priviledged_process, which are
useful for anybody creating  a CGI script.  These headers have information
useful to modules, because they declare either information that defines
how the server is built, or they define functions used by modules.  Just
because a header is in the OS directory, or the MPM directory doesn't mean
it's private, it means that the information changes based on OS or MPM.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Re: cvs commit: httpd-2.0 CHANGES Makefile.in

Posted by Greg Stein <gs...@lyra.org>.
On Wed, Feb 07, 2001 at 07:07:46PM -0000, rbb@apache.org wrote:
> rbb         01/02/07 11:07:46
> 
>   Modified:    .        CHANGES Makefile.in
>   Log:
>   Install all required header files.  Without these, some modules can not
>   be compiled outside the src tree.
>...
>   --- Makefile.in	2001/01/28 20:06:18	1.55
>   +++ Makefile.in	2001/02/07 19:07:46	1.56
>   @@ -105,12 +105,14 @@
>    	@if test -f $(srcdir)/os/$(OS_DIR)/os-inline.c; then \
>                cp -p $(srcdir)/os/$(OS_DIR)/os-inline.c $(includedir); \
>            fi;
>   +	@cp -p $(srcdir)/server/mpm/$(MPM_NAME)/*.h $(includedir)
>    	@cp -p $(srcdir)/modules/dav/main/mod_dav.h $(includedir)
>    	@cp -p $(srcdir)/modules/filters/mod_include.h $(includedir)
>    	@cp -p $(srcdir)/srclib/expat-lite/*.h $(includedir)
>    	@cp -p $(srcdir)/srclib/pcre/*.h $(includedir)
>    	@cp -p $(srcdir)/srclib/apr/include/*.h $(includedir)
>    	@cp -p $(srcdir)/srclib/apr-util/include/*.h $(includedir)
>   +	@cp -p $(srcdir)/os/$(OS_DIR)/*.h $(includedir)
>    	@chmod 644 $(includedir)/*.h

Woah!

Who is using MPM headers? Or the OS headers? Aren't all of those supposed to
be private? e.g. for the MPM, we have a generic, common header that can be
used as an API.

And what in the OS directory needs to be exported?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/