You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/09 13:52:01 UTC
[GitHub] [incubator-devlake] thenicetgp opened a new pull request, #3040: fix: let `check-Apache-license-header` work
thenicetgp opened a new pull request, #3040:
URL: https://github.com/apache/incubator-devlake/pull/3040
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
# Summary
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Does this close any open issues?
Closes xx
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on pull request #3040: fix: let workflow `check-Apache-license-header` work
Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #3040:
URL: https://github.com/apache/incubator-devlake/pull/3040#issuecomment-1242334332
#3032 resolved all linter problems including the license headers, so I think we can close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mindlesscloud merged pull request #3040: fix: let workflow `check-Apache-license-header` work
Posted by GitBox <gi...@apache.org>.
mindlesscloud merged PR #3040:
URL: https://github.com/apache/incubator-devlake/pull/3040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] thenicetgp commented on pull request #3040: fix: let workflow `check-Apache-license-header` work
Posted by GitBox <gi...@apache.org>.
thenicetgp commented on PR #3040:
URL: https://github.com/apache/incubator-devlake/pull/3040#issuecomment-1242755711
> #3032 resolved all linter problems including the license headers, so I think we can close this one.
Tanks for your remind, I undid the commit that added headers to the required files. But I found that the workflow `check Apache license header` in the PR #3032 still doesn't work, so I think this PR is still useful. At the same time,I found there are still two files to add `apache-license-header`.
<img width="1033" alt="Screen Shot 2022-09-10 at 23 19 59" src="https://user-images.githubusercontent.com/47466847/189490630-0d1251e0-2028-4aca-9a94-ddeedfd1406c.png">
<img width="1036" alt="Screen Shot 2022-09-10 at 23 30 44" src="https://user-images.githubusercontent.com/47466847/189490618-45e542f7-d2dd-423a-baa7-7dcbf197d739.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org