You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Shri Javadekar <no...@github.com> on 2013/10/08 01:47:51 UTC
[jclouds] JCLOUDS-334. Return correct status while creating
containers in Swift. (#170)
BlobStore.createContainerInLocation is supposed to return True if the container was newly created and False if the container already existed. This commit makes that happen for Swift blobstores.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds create_container_return_status
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/170
-- Commit Summary --
* JCLOUDS-334. Return correct status while creating containers in Swift.
-- File Changes --
M apis/swift/src/main/java/org/jclouds/openstack/swift/CommonSwiftAsyncClient.java (3)
M apis/swift/src/test/java/org/jclouds/openstack/swift/SwiftClientExpectTest.java (31)
A core/src/main/java/org/jclouds/http/functions/ReturnTrueIf201.java (40)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/170.patch
https://github.com/jclouds/jclouds/pull/170.diff
Re: [jclouds] JCLOUDS-334. Return correct status while creating
containers in Swift. (#170)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #282](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/282/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/170#issuecomment-25855733
Re: [jclouds] JCLOUDS-334. Return correct status while creating
containers in Swift. (#170)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #283](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/283/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/170#issuecomment-25857439
Re: [jclouds] JCLOUDS-334. Return correct status while creating
containers in Swift. (#170)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #744](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/744/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/170#issuecomment-25855744
Re: [jclouds] JCLOUDS-334. Return correct status while creating
containers in Swift. (#170)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #483](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/483/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/170#issuecomment-25859518
Re: [jclouds] JCLOUDS-334. Return correct status while creating
containers in Swift. (#170)
Posted by Andrew Gaul <no...@github.com>.
> @@ -55,6 +55,37 @@ public void testContainerExistsWhenResponseIs2xxReturnsTrue() {
> }
>
> @Test
> + public void testCreateContainerReturnStatus() {
Prefer 3-space indents over 2-space.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/170/files#r6814107
Re: [jclouds] JCLOUDS-334. Return correct status while creating
containers in Swift. (#170)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #745](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/745/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/170#issuecomment-25857471
Re: [jclouds] JCLOUDS-334. Return correct status while creating
containers in Swift. (#170)
Posted by Andrew Phillips <no...@github.com>.
> jclouds » jclouds #483 UNSTABLE
Look like unrelated [test failures](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/483/testReport/), by the way...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/170#issuecomment-25871017
Re: [jclouds] JCLOUDS-334. Return correct status while creating
containers in Swift. (#170)
Posted by Shri Javadekar <no...@github.com>.
> @@ -55,6 +55,37 @@ public void testContainerExistsWhenResponseIs2xxReturnsTrue() {
> }
>
> @Test
> + public void testCreateContainerReturnStatus() {
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/170/files#r6814632
Re: [jclouds] JCLOUDS-334. Return correct status while creating
containers in Swift. (#170)
Posted by Andrew Gaul <no...@github.com>.
Otherwise looks good for master and 1.6.x.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/170#issuecomment-25855488