You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/07 20:47:40 UTC

[GitHub] [superset] eric-briscoe commented on a diff in pull request #21948: feat: Integrate ant d table component into DatasetPanel

eric-briscoe commented on code in PR #21948:
URL: https://github.com/apache/superset/pull/21948#discussion_r1015886053


##########
superset-frontend/packages/superset-ui-core/src/style/index.tsx:
##########
@@ -124,6 +124,11 @@ const defaultTheme = {
       light1: '#B3DEFE',
       light2: '#EFF8FE',
     },
+    shadow: {

Review Comment:
   @pkdotson nice catch, something I meant to run by design and missed! I removed changes to global style in in the create ant d table pr and changes will reflect here as well.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org