[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1080: [HUDI-118]: Options provided for passing properties to Cleaner, compactor and importer commands

[GitBox <gi...@apache.org>]

pratyakshsharma commented on a change in pull request #1080: [HUDI-118]: Options provided for passing properties to Cleaner, compactor and importer commands
URL: https://github.com/apache/incubator-hudi/pull/1080#discussion_r355368831
 
 

 ##########
 File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/CleansCommand.java
 ##########
 @@ -129,4 +125,31 @@ public String showCleanPartitions(@CliOption(key = {"clean"}, help = "clean to s
     return HoodiePrintHelper.print(header, new HashMap<>(), sortByField, descending, limit, headerOnly, rows);
 
   }
+
+  @CliCommand(value = "cleans run", help = "run clean")
+  public String runClean(@CliOption(key = "sparkMemory", unspecifiedDefaultValue = "4G",
+      help = "Spark executor memory") final String sparkMemory,
+                         @CliOption(key = "propsFilePath", help = "path to properties file on localfs or dfs with configurations for hoodie client for cleaning",
+                           unspecifiedDefaultValue = "") final String propsFilePath,
+                         @CliOption(key = "hoodieConfigs", help = "Any configuration that can be set in the properties file can be passed here in the form of an array",
 
 Review comment:
   @n3nash Please refer to this comment by @bvaradar - https://jira.apache.org/jira/browse/HUDI-118?focusedCommentId=16983739&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16983739. 
   
   I was trying to implement as per what is suggested in this comment. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services