You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2017/01/08 13:20:51 UTC
[GitHub] zeppelin pull request #1871: ZEPPELIN-1862 Move packages related Helium into...
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1871
ZEPPELIN-1862 Move packages related Helium into a new module named helium-dev
### What is this PR for?
Reducing zeppelin-interpreter by moving helium files into a new module
### What type of PR is it?
[Improvement]
### Todos
* [x] - Move files into a new module
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1862
### How should this be tested?
If you develop a new helium application, you have to depend helium-dev into your package
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A, AFAIK, there's no helium application for now
* Does this needs documentation? Yes, I'll make a new PR for handling it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1862
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1871.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1871
----
commit fece837887253cd6b45991a5535126d55ac60d8f
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-01-06T13:29:19Z
Removed non-string properties values since it's not used
commit aa4e4ef8007d8786691e550c8541bafde58e34c8
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-01-06T16:57:06Z
Fixed some keys for running interpreter
commit 6239f2860f47371b494d07ab05af4a73ae6eabad
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-01-06T17:57:36Z
Fixed style
commit a107e53b32498ceba4a28143535a3754ea8adc45
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-12-26T16:06:05Z
Made new package for helium-dev
Moved some classes
commit af6b7fb178b109f918a0d52a326b1b8d4f8abd73
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-01-03T14:51:35Z
Removed DevInterpreter from zeppelin-zengine
commit 2432715fccd8f4fa042ea81229bd2bd6bbcb60d4
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-01-06T11:35:44Z
Fixed classpath into new packages
commit 237cd612ec251d390b1c70a1f8c7e013cf8d1ac2
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-01-06T16:52:22Z
Fixed to set DevInterpreter into interpreter variable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1871: ZEPPELIN-1862 Move packages related Helium into a new ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1871
Will merge it if there's no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1871: ZEPPELIN-1862 Move packages related Helium into a new ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1871
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1871: ZEPPELIN-1862 Move packages related Helium into a new ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1871
Tested and it works well :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1871: ZEPPELIN-1862 Move packages related Helium into...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1871
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1871: ZEPPELIN-1862 Move packages related Helium into a new ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1871
@Leemoonsoo @AhyoungRyu @soralee Can you review this PR? you just build it with `-Phelium-dev` and run clock example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---