You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ctakes.apache.org by Tim Miller <ti...@childrens.harvard.edu> on 2013/04/08 21:53:32 UTC

srl bug with one word sentences

I filed a jira (https://issues.apache.org/jira/browse/CTAKES-184) for an 
issue in the srl component of the dependency parser. Here is the issue: 
The SRL component grabs the Dependency Node for each token using the 
token span. When there is a one-word sentence there are two such nodes, 
the "head" node which spans the sentence and the token node. There is a 
quick fix checked in that looks at the "id" field, but it would be 
preferable to fix it upstream so that users of the Dependency types 
don't need to know about this issue.

Here are a few possibilities, any other ideas?
1) Change the span of the head node, maybe to 0 length at the start of 
the sentence?
2) Create a separate type for DependencyTreeHead, perhaps spanless



-- 
Tim Miller, PhD
Postdoctoral Research Fellow
Children's Hospital Informatics Program
Boston Children's Hospital and Harvard Medical School
617-919-1223

RE: srl bug with one word sentences

Posted by "Chen, Pei" <Pe...@childrens.harvard.edu>.
Sounds reasonable. Thanks Tim!
--Pei

> -----Original Message-----
> From: Tim Miller [mailto:timothy.miller@childrens.harvard.edu]
> Sent: Wednesday, May 29, 2013 1:22 PM
> To: dev@ctakes.apache.org
> Subject: Re: srl bug with one word sentences
> 
> There weren't any objections, but I'm not convinced that the new type will
> be an improvement over the fix checked in, so I'm going to mark this issue
> resolved unless someone wants to raise an argument.
> Tim
> 
> On 04/11/2013 09:25 PM, Chen, Pei wrote:
> > My vote would be for 2) Create a DependencyTreeHead which would make
> it explicit similar to ClearTK's
> org.cleartk.syntax.dependency.type.TopDependencyNode.
> >
> > Since there is already a temp fix, we can wait and see if there are any
> objections with adding this type first?
> >
> > --Pei
> > ________________________________________
> > From: Tim Miller [timothy.miller@childrens.harvard.edu]
> > Sent: Monday, April 08, 2013 3:54 PM
> > To: dev@ctakes.apache.org
> > Subject: srl bug with one word sentences
> >
> > I filed a jira (https://issues.apache.org/jira/browse/CTAKES-184) for
> > an issue in the srl component of the dependency parser. Here is the issue:
> > The SRL component grabs the Dependency Node for each token using the
> > token span. When there is a one-word sentence there are two such
> > nodes, the "head" node which spans the sentence and the token node.
> > There is a quick fix checked in that looks at the "id" field, but it
> > would be preferable to fix it upstream so that users of the Dependency
> > types don't need to know about this issue.
> >
> > Here are a few possibilities, any other ideas?
> > 1) Change the span of the head node, maybe to 0 length at the start of
> > the sentence?
> > 2) Create a separate type for DependencyTreeHead, perhaps spanless
> >
> >
> >
> > --
> > Tim Miller, PhD
> > Postdoctoral Research Fellow
> > Children's Hospital Informatics Program Boston Children's Hospital and
> > Harvard Medical School
> > 617-919-1223
> >

Re: srl bug with one word sentences

Posted by Tim Miller <ti...@childrens.harvard.edu>.
There weren't any objections, but I'm not convinced that the new type 
will be an improvement over the fix checked in, so I'm going to mark 
this issue resolved unless someone wants to raise an argument.
Tim

On 04/11/2013 09:25 PM, Chen, Pei wrote:
> My vote would be for 2) Create a DependencyTreeHead which would make it explicit similar to ClearTK's org.cleartk.syntax.dependency.type.TopDependencyNode.
>
> Since there is already a temp fix, we can wait and see if there are any objections with adding this type first?
>
> --Pei
> ________________________________________
> From: Tim Miller [timothy.miller@childrens.harvard.edu]
> Sent: Monday, April 08, 2013 3:54 PM
> To: dev@ctakes.apache.org
> Subject: srl bug with one word sentences
>
> I filed a jira (https://issues.apache.org/jira/browse/CTAKES-184) for an
> issue in the srl component of the dependency parser. Here is the issue:
> The SRL component grabs the Dependency Node for each token using the
> token span. When there is a one-word sentence there are two such nodes,
> the "head" node which spans the sentence and the token node. There is a
> quick fix checked in that looks at the "id" field, but it would be
> preferable to fix it upstream so that users of the Dependency types
> don't need to know about this issue.
>
> Here are a few possibilities, any other ideas?
> 1) Change the span of the head node, maybe to 0 length at the start of
> the sentence?
> 2) Create a separate type for DependencyTreeHead, perhaps spanless
>
>
>
> --
> Tim Miller, PhD
> Postdoctoral Research Fellow
> Children's Hospital Informatics Program
> Boston Children's Hospital and Harvard Medical School
> 617-919-1223
>

RE: srl bug with one word sentences

Posted by "Chen, Pei" <Pe...@childrens.harvard.edu>.
My vote would be for 2) Create a DependencyTreeHead which would make it explicit similar to ClearTK's org.cleartk.syntax.dependency.type.TopDependencyNode.

Since there is already a temp fix, we can wait and see if there are any objections with adding this type first?

--Pei
________________________________________
From: Tim Miller [timothy.miller@childrens.harvard.edu]
Sent: Monday, April 08, 2013 3:54 PM
To: dev@ctakes.apache.org
Subject: srl bug with one word sentences

I filed a jira (https://issues.apache.org/jira/browse/CTAKES-184) for an
issue in the srl component of the dependency parser. Here is the issue:
The SRL component grabs the Dependency Node for each token using the
token span. When there is a one-word sentence there are two such nodes,
the "head" node which spans the sentence and the token node. There is a
quick fix checked in that looks at the "id" field, but it would be
preferable to fix it upstream so that users of the Dependency types
don't need to know about this issue.

Here are a few possibilities, any other ideas?
1) Change the span of the head node, maybe to 0 length at the start of
the sentence?
2) Create a separate type for DependencyTreeHead, perhaps spanless



--
Tim Miller, PhD
Postdoctoral Research Fellow
Children's Hospital Informatics Program
Boston Children's Hospital and Harvard Medical School
617-919-1223