You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/09/02 21:31:45 UTC
Re: Review Request 37173: Maintenance Primitives: Added
unavailability to Allocator's Slave struct.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 7:31 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
include/mesos/master/allocator.proto 10fd9a2d5fcbc18a9ca2d6c9c0ec1c605f21872b
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
src/tests/hierarchical_allocator_tests.cpp 9748ca0b38888fee25dcec51c64d8ba84dbd4aaf
src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24
src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569
src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b
src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23
Diff: https://reviews.apache.org/r/37173/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37173: Maintenance Primitives: Added
unavailability to Allocator's Slave struct.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/#review98529
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/hierarchical.hpp (line 272)
<https://reviews.apache.org/r/37173/#comment155045>
Seems like this entire thing could be the InverseOfferResponse protobuf?
- Benjamin Hindman
On Sept. 2, 2015, 7:31 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37173/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 7:31 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> include/mesos/master/allocator.proto 10fd9a2d5fcbc18a9ca2d6c9c0ec1c605f21872b
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
> src/tests/hierarchical_allocator_tests.cpp 9748ca0b38888fee25dcec51c64d8ba84dbd4aaf
> src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24
> src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569
> src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b
> src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23
>
> Diff: https://reviews.apache.org/r/37173/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37173: Maintenance Primitives: Added
unavailability to Allocator's Slave struct.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/#review98797
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/hierarchical.hpp (line 296)
<https://reviews.apache.org/r/37173/#comment155396>
With all the great cleanup here I wonder now if we should do 'Option<Maintenance> maintenance' similar to how we had a 'Maintenance' struct in master to capture all the maintenance specific bits. Otherwise, these changes look great to me!
- Benjamin Hindman
On Sept. 13, 2015, 8:32 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37173/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:32 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> include/mesos/master/allocator.proto 10fd9a2d5fcbc18a9ca2d6c9c0ec1c605f21872b
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/hierarchical_allocator_tests.cpp 9748ca0b38888fee25dcec51c64d8ba84dbd4aaf
> src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24
> src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
> src/tests/reservation_endpoints_tests.cpp dfab4971e04a81ac98ed118ea877bcca5db17bb5
> src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b
> src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5
>
> Diff: https://reviews.apache.org/r/37173/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37173: Maintenance Primitives: Added
unavailability to Allocator's Slave struct.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 12:40 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Renamed `MaintenanceStatus` to `Maintenance`
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
include/mesos/master/allocator.proto 10fd9a2d5fcbc18a9ca2d6c9c0ec1c605f21872b
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
src/tests/hierarchical_allocator_tests.cpp 9748ca0b38888fee25dcec51c64d8ba84dbd4aaf
src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24
src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
src/tests/reservation_endpoints_tests.cpp dfab4971e04a81ac98ed118ea877bcca5db17bb5
src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b
src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5
Diff: https://reviews.apache.org/r/37173/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37173: Maintenance Primitives: Added
unavailability to Allocator's Slave struct.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/
-----------------------------------------------------------
(Updated Sept. 13, 2015, 8:32 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
include/mesos/master/allocator.proto 10fd9a2d5fcbc18a9ca2d6c9c0ec1c605f21872b
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
src/tests/hierarchical_allocator_tests.cpp 9748ca0b38888fee25dcec51c64d8ba84dbd4aaf
src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24
src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
src/tests/reservation_endpoints_tests.cpp dfab4971e04a81ac98ed118ea877bcca5db17bb5
src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b
src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5
Diff: https://reviews.apache.org/r/37173/diff/
Testing
-------
Thanks,
Joris Van Remoortere