You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by sansanichfb <gi...@git.apache.org> on 2016/12/05 21:51:57 UTC
[GitHub] incubator-hawq pull request #1039: HAWQ-1191. Decomissioned DELIMITER from H...
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/1039
HAWQ-1191. Decomissioned DELIMITER from HiveOrc profile.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sansanichfb/incubator-hawq HAWQ-1191
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1039.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1039
----
commit 98690c519ade2e909357b6c88ccc8ce4452e2ec1
Author: Oleksandr Diachenko <od...@pivotal.io>
Date: 2016-12-05T21:41:34Z
HAWQ-1191. Decomissioned DELIMITER from HiveOrc profile.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1039: HAWQ-1191. Decomissioned DELIMITER from H...
Posted by kavinderd <gi...@git.apache.org>.
Github user kavinderd commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1039#discussion_r91353048
--- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveResolver.java ---
@@ -79,7 +79,7 @@
private String serdeName;
private String propsString;
String partitionKeys;
- char delimiter;
+ char delimiter = 1;
--- End diff --
Why do we even need this value anymore?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1039: HAWQ-1191. Decomissioned DELIMITER from H...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1039
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1039: HAWQ-1191. Decomissioned DELIMITER from HiveOrc ...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on the issue:
https://github.com/apache/incubator-hawq/pull/1039
I'm a bit concerned about the impact of removing this function parseDelimiterChar completely without completely understand the impact of it w.r.t Partition filtering. Lets merge this change once we verify that Partition based filtering works fine with all the Hive related profiles
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1039: HAWQ-1191. Decomissioned DELIMITER from H...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1039#discussion_r91148521
--- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveResolver.java ---
@@ -79,7 +79,7 @@
private String serdeName;
private String propsString;
String partitionKeys;
- char delimiter;
+ char delimiter = 1;
--- End diff --
Why specifically set it to 1 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1039: HAWQ-1191. Decomissioned DELIMITER from HiveOrc ...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on the issue:
https://github.com/apache/incubator-hawq/pull/1039
@shivzone, @kavinderd I double checked for HiveRc and HiveText - they still need delimiter, which should be exposed to users, so in this PR I just removed DELIMITER for HiveOrc profile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1039: HAWQ-1191. Decomissioned DELIMITER from HiveOrc ...
Posted by kavinderd <gi...@git.apache.org>.
Github user kavinderd commented on the issue:
https://github.com/apache/incubator-hawq/pull/1039
So the delimiter we were previously explicitly asking for in the DDL will just be retrieved internally?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---