You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "seawinde (via GitHub)" <gi...@apache.org> on 2024/02/29 06:43:59 UTC

[PR] [fix](Neredis) Fix npe when plan node doesn't have expressions in materialized view [doris]

seawinde opened a new pull request, #31579:
URL: https://github.com/apache/doris/pull/31579

   ## Proposed changes
   
   Fix npe when plan node doesn't have expressions in materialized view
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Neredis) Fix npe when plan node doesn't have expressions in materialized view [doris]

Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #31579:
URL: https://github.com/apache/doris/pull/31579#issuecomment-1970507184

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Neredis) Fix npe when plan node doesn't have expressions in materialized view [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31579:
URL: https://github.com/apache/doris/pull/31579#issuecomment-1970555695

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 7fb9d7c118dc6a65c595eb5e0381a3e9fa8b3472 with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
   Insert into select:       18.8 seconds inserted 10000000 Rows, about 531K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Neredis) Fix npe when plan node doesn't have expressions in materialized view [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31579:
URL: https://github.com/apache/doris/pull/31579#issuecomment-1970506420

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Neredis) Fix npe when plan node doesn't have expressions in materialized view [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31579:
URL: https://github.com/apache/doris/pull/31579#issuecomment-1970508482

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Neredis) Fix npe when plan node doesn't have expressions in materialized view [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31579:
URL: https://github.com/apache/doris/pull/31579#issuecomment-1970508521

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Neredis) Fix npe when plan node doesn't have expressions in materialized view [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31579:
URL: https://github.com/apache/doris/pull/31579


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Neredis) Fix npe when plan node doesn't have expressions in materialized view [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31579:
URL: https://github.com/apache/doris/pull/31579#issuecomment-1970533886

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38040 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 7fb9d7c118dc6a65c595eb5e0381a3e9fa8b3472, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17664	4101	4037	4037
   q2	2039	143	132	132
   q3	10578	1010	941	941
   q4	4655	953	951	951
   q5	7613	2897	3044	2897
   q6	182	125	123	123
   q7	1240	772	762	762
   q8	9239	1920	2028	1920
   q9	7163	6318	6286	6286
   q10	8194	2484	2516	2484
   q11	418	200	197	197
   q12	748	309	304	304
   q13	17967	3242	3240	3240
   q14	278	253	242	242
   q15	538	496	497	496
   q16	482	408	411	408
   q17	931	908	870	870
   q18	6774	6088	6172	6088
   q19	1585	1524	1513	1513
   q20	546	279	275	275
   q21	6853	3583	3589	3583
   q22	791	304	291	291
   Total cold run time: 106478 ms
   Total hot run time: 38040 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4045	4009	4015	4009
   q2	304	211	218	211
   q3	3004	2974	2951	2951
   q4	1826	1814	1800	1800
   q5	5156	5165	5171	5165
   q6	200	114	114	114
   q7	2131	1764	1697	1697
   q8	3129	3187	3203	3187
   q9	8314	8264	8234	8234
   q10	6096	3673	3631	3631
   q11	516	426	427	426
   q12	700	534	520	520
   q13	5679	3051	3057	3051
   q14	275	252	257	252
   q15	540	499	496	496
   q16	509	474	454	454
   q17	1691	1693	1691	1691
   q18	7870	7704	7517	7517
   q19	1641	1637	1632	1632
   q20	2095	1923	1906	1906
   q21	4919	4597	4595	4595
   q22	500	439	443	439
   Total cold run time: 61140 ms
   Total hot run time: 53978 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Neredis) Fix npe when plan node doesn't have expressions in materialized view [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31579:
URL: https://github.com/apache/doris/pull/31579#issuecomment-1970545720

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 168830 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 7fb9d7c118dc6a65c595eb5e0381a3e9fa8b3472, data reload: false
   
   query1	937	353	343	343
   query2	6563	1645	1757	1645
   query3	6702	201	199	199
   query4	23401	20473	20534	20473
   query5	4250	367	353	353
   query6	262	172	171	171
   query7	4602	303	291	291
   query8	253	192	193	192
   query9	8508	2227	2231	2227
   query10	415	212	224	212
   query11	14638	14109	14208	14109
   query12	130	81	82	81
   query13	1661	427	426	426
   query14	8334	6451	6308	6308
   query15	208	169	172	169
   query16	7092	262	257	257
   query17	1032	526	502	502
   query18	1895	262	264	262
   query19	191	148	140	140
   query20	88	80	83	80
   query21	202	118	129	118
   query22	4625	4528	4575	4528
   query23	30607	29913	29921	29913
   query24	12107	3144	3130	3130
   query25	661	359	334	334
   query26	1891	154	166	154
   query27	3056	312	314	312
   query28	7022	1826	1813	1813
   query29	1189	556	553	553
   query30	286	131	139	131
   query31	861	680	693	680
   query32	96	57	58	57
   query33	712	230	218	218
   query34	1071	475	477	475
   query35	846	747	763	747
   query36	947	910	892	892
   query37	144	59	64	59
   query38	3096	2962	2982	2962
   query39	1318	1262	1251	1251
   query40	279	100	99	99
   query41	39	37	35	35
   query42	108	93	102	93
   query43	452	461	453	453
   query44	1060	695	709	695
   query45	189	183	173	173
   query46	1049	785	774	774
   query47	1505	1409	1467	1409
   query48	402	360	344	344
   query49	1155	288	294	288
   query50	761	361	360	360
   query51	4373	4275	4279	4275
   query52	107	92	88	88
   query53	341	262	261	261
   query54	304	212	221	212
   query55	82	78	76	76
   query56	224	202	199	199
   query57	953	875	913	875
   query58	226	192	194	192
   query59	2128	2012	2104	2012
   query60	241	215	219	215
   query61	85	92	82	82
   query62	600	370	348	348
   query63	275	254	271	254
   query64	6540	2998	3158	2998
   query65	3228	3219	3229	3219
   query66	1434	320	319	319
   query67	14359	14148	14214	14148
   query68	4985	553	551	551
   query69	524	366	373	366
   query70	1282	1204	1147	1147
   query71	322	253	256	253
   query72	6238	2804	2666	2666
   query73	712	316	320	316
   query74	6310	6001	5914	5914
   query75	3067	2419	2411	2411
   query76	2793	1049	1141	1049
   query77	347	234	228	228
   query78	9072	8444	8502	8444
   query79	1721	506	541	506
   query80	1073	351	344	344
   query81	502	193	198	193
   query82	926	84	86	84
   query83	229	120	118	118
   query84	281	75	81	75
   query85	1390	348	356	348
   query86	440	304	307	304
   query87	3275	3073	3067	3067
   query88	2746	2247	2237	2237
   query89	385	329	326	326
   query90	1937	161	162	161
   query91	159	121	126	121
   query92	56	49	48	48
   query93	1651	526	511	511
   query94	1282	178	180	178
   query95	444	342	347	342
   query96	577	259	265	259
   query97	4239	4180	4163	4163
   query98	204	216	190	190
   query99	1045	647	662	647
   Total cold run time: 264612 ms
   Total hot run time: 168830 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Neredis) Fix npe when plan node doesn't have expressions in materialized view [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31579:
URL: https://github.com/apache/doris/pull/31579#issuecomment-1970551809

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.91 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 7fb9d7c118dc6a65c595eb5e0381a3e9fa8b3472, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.07	0.02	0.03
   query3	0.23	0.06	0.06
   query4	1.66	0.10	0.10
   query5	0.52	0.51	0.52
   query6	1.40	0.68	0.66
   query7	0.02	0.01	0.01
   query8	0.03	0.03	0.03
   query9	0.55	0.51	0.52
   query10	0.57	0.56	0.57
   query11	0.13	0.10	0.10
   query12	0.12	0.10	0.10
   query13	0.62	0.61	0.62
   query14	0.79	0.80	0.81
   query15	0.84	0.83	0.81
   query16	0.36	0.35	0.40
   query17	1.01	0.96	0.96
   query18	0.26	0.25	0.25
   query19	1.80	1.72	1.76
   query20	0.02	0.01	0.01
   query21	15.39	0.65	0.64
   query22	2.88	4.82	3.16
   query23	17.64	1.17	1.00
   query24	2.31	0.26	0.20
   query25	0.19	0.11	0.06
   query26	0.18	0.13	0.14
   query27	0.03	0.03	0.02
   query28	12.43	0.84	0.83
   query29	12.59	3.32	3.42
   query30	0.58	0.54	0.53
   query31	2.79	0.35	0.36
   query32	3.33	0.48	0.48
   query33	3.20	3.33	3.21
   query34	15.36	4.75	4.74
   query35	4.79	4.71	4.72
   query36	1.14	1.07	1.07
   query37	0.07	0.05	0.05
   query38	0.04	0.03	0.02
   query39	0.02	0.02	0.02
   query40	0.19	0.13	0.14
   query41	0.07	0.02	0.01
   query42	0.02	0.01	0.02
   query43	0.03	0.02	0.02
   Total cold run time: 106.31 s
   Total hot run time: 32.91 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org