You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/16 09:26:07 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue #6073: dateTimeUpper never used in FixedIntervalShardingAlgorithm
terrymanu opened a new issue #6073:
URL: https://github.com/apache/shardingsphere/issues/6073
The field dateTimeUpper never used in FixedIntervalShardingAlgorithm, please check the usage and document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #6073: dateTimeUpper never used in FixedIntervalShardingAlgorithm
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #6073:
URL: https://github.com/apache/shardingsphere/issues/6073#issuecomment-645146736
@terrymanu Thanks for your issue.
I dug the commit history and found `private LocalDateTime dateTimeUpper;` is what you added. My commit record told me I did not need this member.
Please give it a look, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero closed issue #6073: dateTimeUpper never used in AutoIntervalShardingAlgorithm
Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #6073:
URL: https://github.com/apache/shardingsphere/issues/6073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #6073: dateTimeUpper never used in FixedIntervalShardingAlgorithm
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #6073:
URL: https://github.com/apache/shardingsphere/issues/6073#issuecomment-645169224
Ok, maybe wrong for copy, we can remove this field
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org