[jira] [Comment Edited] (CB-8976) platforms/android/build.gradle modifies android versionCode

["Brent Dearth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-8976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151419#comment-15151419 ] 

Brent Dearth edited comment on CB-8976 at 2/17/16 11:31 PM:
------------------------------------------------------------

Yep ... any automatic determination or alteration to versionCode was a horrible idea from the start and has left a lot of people with extreme confusion. Furthermore, once you upload an APK to any channel (including alpha), you're trapped by the new floor. As a workaround we've had to pad with some unnecessary prefixing and are now approaching maxInt territory. Whee!


was (Author: booleanbetrayal):
Yep ... any alteration to versionCode was a horrible idea from the start and has left a lot of people with extreme confusion. Furthermore, once you upload an APK to any channel (including alpha), you're trapped by the new floor. As a workaround we've had to pad with some unnecessary prefixing and are now approaching maxInt territory. Whee!

> platforms/android/build.gradle modifies android versionCode
> -----------------------------------------------------------
>
>                 Key: CB-8976
>                 URL: https://issues.apache.org/jira/browse/CB-8976
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>         Environment: Android
>            Reporter: zack dykes
>
> cordova 5.0.0
> platforms/android/build.gradle modifies android versionCode at ln 178
> as I understand it max size for versionCode is (2^31)-1 
> http://stackoverflow.com/a/24246191/126600
> in my config.xml: 
> {code}
> android-versionCode="1385039613"
> {code}
> when I run {{cordova build android}}, I get:
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file '/Users/zackd/dev/code/cordova/cordova-ansr-fat-client/ondeviceresearch/platforms/android/build.gradle' line: 178
> * What went wrong:
> A problem occurred evaluating root project 'android'.
> > For input string: "13850396130"
> {code}
> and build.gradle, ln 178
> {code}
> versionCode cdvVersionCode ?: Integer.parseInt("" + privateHelpers.extractIntFromManifest("versionCode") + "0")
> {code}
> looks like this is appending "0" to my versionCode, producing 13850396130 which is larger than max size for android versionCode
> if I mod ln 178 as follows, build succeeds
> {code}
> versionCode cdvVersionCode ?: Integer.parseInt("" + privateHelpers.extractIntFromManifest("versionCode"))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org