You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "nic-6443 (via GitHub)" <gi...@apache.org> on 2026/01/06 02:57:37 UTC

[PR] fix: mcp-bridge flaky test [apisix]

nic-6443 opened a new pull request, #12863:
URL: https://github.com/apache/apisix/pull/12863

   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   #### Which issue(s) this PR fixes:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   -->
   Fixes #
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: mcp-bridge flaky test [apisix]

Posted by "LiteSun (via GitHub)" <gi...@apache.org>.
LiteSun merged PR #12863:
URL: https://github.com/apache/apisix/pull/12863


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: mcp-bridge flaky test [apisix]

Posted by "membphis (via GitHub)" <gi...@apache.org>.
membphis commented on code in PR #12863:
URL: https://github.com/apache/apisix/pull/12863#discussion_r2681610515


##########
ci/prepare_filesystem_mcp.sh:
##########
@@ -0,0 +1,47 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#!/usr/bin/env bash
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+REPO_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)"
+
+VERSION="2025.7.1"
+URL="https://github.com/modelcontextprotocol/servers/archive/refs/tags/${VERSION}.tar.gz"
+
+WORKDIR="$(mktemp -d)"
+DEST_DIR="${REPO_ROOT}/t/plugin/mcp/servers"
+
+curl -L "${URL}" | tar -xz -C "${WORKDIR}"
+
+rm -rf "${DEST_DIR}"
+mkdir -p "$(dirname "${DEST_DIR}")"
+
+cp -R "${WORKDIR}/servers-${VERSION}" "${DEST_DIR}"
+
+(
+  cd "${DEST_DIR}"
+  npm install
+  # Note: Although dlx specifies the package version, it does not use a lockfile, 

Review Comment:
   nice, it is really important and useful information



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: mcp-bridge flaky test [apisix]

Posted by "LiteSun (via GitHub)" <gi...@apache.org>.
LiteSun commented on PR #12863:
URL: https://github.com/apache/apisix/pull/12863#issuecomment-3726766711

   > @LiteSun still one test case failed, pls fix it
   
   done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: mcp-bridge flaky test [apisix]

Posted by "membphis (via GitHub)" <gi...@apache.org>.
membphis commented on PR #12863:
URL: https://github.com/apache/apisix/pull/12863#issuecomment-3721761284

   @LiteSun still one test case failed, pls fix it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: mcp-bridge flaky test [apisix]

Posted by "LiteSun (via GitHub)" <gi...@apache.org>.
LiteSun commented on code in PR #12863:
URL: https://github.com/apache/apisix/pull/12863#discussion_r2674730906


##########
t/plugin/mcp/assets/package-lock.json:
##########


Review Comment:
   > You have already extracted and copied package-lock.json from the archive package. Does this still need to be committed separately?
   
   Good catch. I didn’t notice before that there was already a lock file at the npm workspace level. It has been updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: mcp-bridge flaky test [apisix]

Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 commented on code in PR #12863:
URL: https://github.com/apache/apisix/pull/12863#discussion_r2674642701


##########
t/plugin/mcp/assets/package-lock.json:
##########


Review Comment:
   You have already extracted and copied package-lock.json from the archive package. Does this still need to be committed separately?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org