You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2026/05/08 19:46:10 UTC
(datasketches-memory) branch update_7.0.X created (now 46781c26)
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a change to branch update_7.0.X
in repository https://gitbox.apache.org/repos/asf/datasketches-memory.git
at 46781c26 Update 7.0.X
This branch includes the following new commits:
new 46781c26 Update 7.0.X
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
(datasketches-memory) 01/01: Update 7.0.X
Posted by le...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch update_7.0.X
in repository https://gitbox.apache.org/repos/asf/datasketches-memory.git
commit 46781c26e8fba8d0f1788da39f281cbb3fe8fd3a
Author: Lee Rhodes <le...@gmail.com>
AuthorDate: Fri May 8 12:45:54 2026 -0700
Update 7.0.X
---
.../apache/datasketches/memory/internal/Util.java | 35 ----------------------
.../datasketches/memory/internal/UtilTest.java | 21 +------------
2 files changed, 1 insertion(+), 55 deletions(-)
diff --git a/datasketches-memory-java11/src/main/java/org/apache/datasketches/memory/internal/Util.java b/datasketches-memory-java11/src/main/java/org/apache/datasketches/memory/internal/Util.java
index 0c9f037e..59cb8bbf 100644
--- a/datasketches-memory-java11/src/main/java/org/apache/datasketches/memory/internal/Util.java
+++ b/datasketches-memory-java11/src/main/java/org/apache/datasketches/memory/internal/Util.java
@@ -282,18 +282,6 @@ public final class Util {
}
} //End class RandomCodePoints
- /**
- * Checks if given value is ≤ zero.
- * @param value the given value
- * @param arg a meaningful name of the actual argument.
- * @throws IllegalArgumentException if value is ≤ 0.
- */
- public static final void zeroCheck(final long value, final String arg) {
- if (value <= 0) {
- throw new IllegalArgumentException("The argument '" + arg + "' may not be negative or zero.");
- }
- }
-
/**
* Checks if given value is < zero.
* @param value the given value
@@ -306,20 +294,6 @@ public final class Util {
}
}
- /**
- * Checks if given value is null.
- * @param obj the given object
- * @param arg a meaningful name of the actual argument.
- * @throws IllegalArgumentException if value is null.
- */
- public static final void nullCheck(final Object obj, final String arg) {
- if (obj == null) {
- throw new IllegalArgumentException("The argument '" + arg + "' may not be null.");
- }
- }
-
- //Resources NOTE: these 3 methods are duplicated in Java/ datasketches/Util
-
/**
* Gets the Path of the given resource file's shortName.
*
@@ -346,15 +320,6 @@ public final class Util {
}
}
-// /**
-// * Gets the file defined by the given resource file's shortFileName.
-// * @param shortFileName the last name in the pathname's name sequence.
-// * @return the file defined by the given resource file's shortFileName.
-// */
-// public static File getResourceFile(final String shortFileName) {
-// return new File(getResourcePath(shortFileName));
-// }
-
/**
* Returns a byte array of the contents of the file defined by the given resource file's
* shortFileName.
diff --git a/datasketches-memory-java11/src/test/java/org/apache/datasketches/memory/internal/UtilTest.java b/datasketches-memory-java11/src/test/java/org/apache/datasketches/memory/internal/UtilTest.java
index 0bb9580e..da03f621 100644
--- a/datasketches-memory-java11/src/test/java/org/apache/datasketches/memory/internal/UtilTest.java
+++ b/datasketches-memory-java11/src/test/java/org/apache/datasketches/memory/internal/UtilTest.java
@@ -17,18 +17,12 @@
* under the License.
*/
-/*
- * Note: Lincoln's Gettysburg Address is in the public domain. See LICENSE.
- */
-
package org.apache.datasketches.memory.internal;
import static org.apache.datasketches.memory.internal.Util.characterPad;
import static org.apache.datasketches.memory.internal.Util.getResourceBytes;
import static org.apache.datasketches.memory.internal.Util.getResourceFile;
import static org.apache.datasketches.memory.internal.Util.negativeCheck;
-import static org.apache.datasketches.memory.internal.Util.nullCheck;
-import static org.apache.datasketches.memory.internal.Util.zeroCheck;
import static org.apache.datasketches.memory.internal.Util.zeroPad;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;
@@ -83,20 +77,7 @@ public class UtilTest {
}
@Test
- public void checkNullZeroNegativeChecks() {
- Object obj = null;
- try {
- nullCheck(obj, "Test Object");
- fail();
- } catch (IllegalArgumentException e) {
- //OK
- }
- try {
- zeroCheck(0, "Test Long");
- fail();
- } catch (IllegalArgumentException e) {
- //OK
- }
+ public void checkNegativeChecks() {
try {
negativeCheck(-1L, "Test Long");
fail();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org