You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "David Li (Jira)" <ji...@apache.org> on 2021/12/16 17:50:00 UTC
[jira] [Commented] (ARROW-15138) [C++] Make ExecPlan::ToString give some additional information
[ https://issues.apache.org/jira/browse/ARROW-15138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460926#comment-17460926 ]
David Li commented on ARROW-15138:
----------------------------------
One thing that's been requested is to have a way to rebuild an exec plan printed in one language (e.g. so that we can get an ExecPlan from R into C++ for debugging).
Doing that fully automatically is out of scope here (though: do we want some way to serialize an ExecPlan to/from an internal format? Or is that redundant with Substrait support?) but we should ensure all necessary data is included.
For options like indentation, we could add an (optional) options struct for those things. (It may also be hard in the general case because plans are not necessarily trees.) Otherwise I agree with the suggested improvements. One more thing to consider might be to ensure we generate unique names in case there are duplicate nodes (I think we already do so since we number them?)
> [C++] Make ExecPlan::ToString give some additional information
> --------------------------------------------------------------
>
> Key: ARROW-15138
> URL: https://issues.apache.org/jira/browse/ARROW-15138
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: C++
> Reporter: Percy Camilo Triveño Aucahuasi
> Priority: Minor
> Labels: compute, engine
>
> Currently we have this task https://issues.apache.org/jira/browse/ARROW-14233 However, that task is very open about the scope. So this ticket will try to address some improvements for ExecPlan::ToString without the need to have additional sophistication nor to extend the scope of features for ExecPlan::ToString.
> This means that we won't need to research about GraphViz (or other backends) here. We will just need to work to have these features for ExecPlan::ToString:
> * Print index/Id for each node in the physical tree
> * Make sure all the nodes have names and correct index/IDs
> * Apply indentation for the printing process (this may be an optional setting in the API)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)