You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2019/02/01 07:47:00 UTC
[jira] [Updated] (WICKET-6184) Remove form argument from AjaxButton
and AjaxSubmitLink callbacks
[ https://issues.apache.org/jira/browse/WICKET-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-6184:
------------------------------------
Description:
AjaxButton and AjaxSubmitLink supply the submitted form in their submit hooks, e.g.:
{code}
protected void onSubmit(AjaxRequestTarget target, Form<?> form)
{code}
The form is superfluous, since it is already available via #getForm().
We decided to remove this parameter, bringing the hooks in line with the new static lambda factories, e.g.:
{code}
public static AjaxSubmitLink onSubmit(String id, WicketBiConsumer<AjaxSubmitLink, AjaxRequestTarget> onSubmit)
{code}
Relevant discussion: http://wicket-dev.markmail.org/thread/vzzntc6wbjub3fad
was:
AjaxButton and AjaxLink supply the submitted form in their submit hooks, e.g.:
{code}
protected void onSubmit(AjaxRequestTarget target, Form<?> form)
{code}
The form is superfluous, since it is already available via #getForm().
We decided to remove this parameter, bringing the hooks in line with the new static lambda factories, e.g.:
{code}
public static AjaxSubmitLink onSubmit(String id, WicketBiConsumer<AjaxSubmitLink, AjaxRequestTarget> onSubmit)
{code}
Relevant discussion: http://wicket-dev.markmail.org/thread/vzzntc6wbjub3fad
> Remove form argument from AjaxButton and AjaxSubmitLink callbacks
> -----------------------------------------------------------------
>
> Key: WICKET-6184
> URL: https://issues.apache.org/jira/browse/WICKET-6184
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 8.0.0-M1
> Reporter: Sven Meier
> Assignee: Sven Meier
> Priority: Trivial
> Fix For: 8.0.0-M1
>
>
> AjaxButton and AjaxSubmitLink supply the submitted form in their submit hooks, e.g.:
> {code}
> protected void onSubmit(AjaxRequestTarget target, Form<?> form)
> {code}
> The form is superfluous, since it is already available via #getForm().
> We decided to remove this parameter, bringing the hooks in line with the new static lambda factories, e.g.:
> {code}
> public static AjaxSubmitLink onSubmit(String id, WicketBiConsumer<AjaxSubmitLink, AjaxRequestTarget> onSubmit)
> {code}
> Relevant discussion: http://wicket-dev.markmail.org/thread/vzzntc6wbjub3fad
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)