You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/04/29 06:31:17 UTC
[GitHub] [incubator-doris] xinghuayu007 opened a new pull request #5733: [Metric] Metric for table/partition level query count
xinghuayu007 opened a new pull request #5733:
URL: https://github.com/apache/incubator-doris/pull/5733
## Proposed changes
Add query count metric for a table and partition. By this metric, we can find a table or a partition is no any read on it for a long time, that the data on it should be deleted to reduce the cost. It is meaningful.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 closed pull request #5733: [Metric] Metric for table/partition level query count
Posted by GitBox <gi...@apache.org>.
xinghuayu007 closed pull request #5733:
URL: https://github.com/apache/incubator-doris/pull/5733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #5733: [Metric] Metric for table/partition level query count
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #5733:
URL: https://github.com/apache/incubator-doris/pull/5733#discussion_r623184517
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Partition.java
##########
@@ -500,4 +508,17 @@ public boolean convertRandomDistributionToHashDistribution(List<Column> baseSche
}
return hasChanged;
}
+
+ private static void registerMetric(Partition partition) {
+ GaugeMetric<Long> gauge = new GaugeMetric<Long>("partition_query_count",
+ Metric.MetricUnit.NOUNIT, "partition query count") {
+ @Override
+ public Long getValue() {
+ return partition.partition_query_count.longValue();
+ }
+ };
+ gauge.addLabel(new MetricLabel("partition_name", partition.getName()));
+ gauge.addLabel(new MetricLabel("partition_id", String.valueOf(partition.getId())));
+ MetricRepo.addMetric(gauge);
Review comment:
Are you sure to add gauge for each partition? There will be a huge number of metrics...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on a change in pull request #5733: [Metric] Metric for table/partition level query count
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on a change in pull request #5733:
URL: https://github.com/apache/incubator-doris/pull/5733#discussion_r623534358
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Partition.java
##########
@@ -500,4 +508,17 @@ public boolean convertRandomDistributionToHashDistribution(List<Column> baseSche
}
return hasChanged;
}
+
+ private static void registerMetric(Partition partition) {
+ GaugeMetric<Long> gauge = new GaugeMetric<Long>("partition_query_count",
+ Metric.MetricUnit.NOUNIT, "partition query count") {
+ @Override
+ public Long getValue() {
+ return partition.partition_query_count.longValue();
+ }
+ };
+ gauge.addLabel(new MetricLabel("partition_name", partition.getName()));
+ gauge.addLabel(new MetricLabel("partition_id", String.valueOf(partition.getId())));
+ MetricRepo.addMetric(gauge);
Review comment:
Adding metrics for partition is to find zero-read partition for the consideration of cost. In a cluster of 30 DBS, every db has 30 tables, every table has 100 partitions. There will be 90000 partition metrics. That is acceptable. In BE, every tablet has 3 metrics. The number of tablet metric is much larger than partition metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org