You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Hudson (Commented) (JIRA)" <ji...@apache.org> on 2011/10/17 02:34:12 UTC

[jira] [Commented] (OGNL-28) Visitor pattern needs way to propagate exceptions.

    [ https://issues.apache.org/jira/browse/OGNL-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128549#comment-13128549 ] 

Hudson commented on OGNL-28:
----------------------------

Integrated in ognl #142 (See [https://builds.apache.org/job/ognl/142/])
    added OGNL-28 issue
OGNL-28 - Visitor pattern needs way to propagate exceptions. (contributed by Daniel Pitts)

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1184965
Files : 
* /commons/proper/ognl/trunk/src/changes/changes.xml

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1184964
Files : 
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAdd.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAnd.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAssign.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitAnd.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitNegate.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitOr.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTConst.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTCtor.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTDivide.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEq.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEval.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTGreater.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTGreaterEq.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTIn.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTInstanceof.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTKeyValue.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTLess.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTLessEq.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTList.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMap.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMultiply.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNegate.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNot.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotEq.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotIn.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTOr.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProject.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRemainder.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRootVarRef.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelect.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectFirst.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectLast.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSequence.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTShiftLeft.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTShiftRight.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticField.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSubtract.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTTest.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTThisVarRef.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTUnsignedShiftRight.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTVarRef.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTXor.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/Node.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NodeVisitor.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/SimpleNode.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ToStringVisitor.java

                
> Visitor pattern needs way to propagate exceptions.
> --------------------------------------------------
>
>                 Key: OGNL-28
>                 URL: https://issues.apache.org/jira/browse/OGNL-28
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Daniel Pitts
>         Attachments: Visitor_with_exceptions.patch
>
>
> The previous patch I created for NodeVisitor neglects the fact that some visitors may wish to throw exceptions. I've created a patch in which all "accept" and "visit" methods throw OgnlException.
> Patch to come.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira