[GitHub] [incubator-druid] jihoonson commented on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks

[GitBox <gi...@apache.org>]

jihoonson commented on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks
URL: https://github.com/apache/incubator-druid/issues/7238#issuecomment-479248286
 
 
   @justinborromeo thank you for the proposal!
   
   It looks good to me, but I have one suggestion. We currently have `maxTotalRows` to suppress the total number of rows across all segments being generated at the same time. This sometimes works well, but I feel it's not easy to control because we don't know what its value means exactly (I'm still not sure what is a good default value for it). However, `maxTotalSegments` is quite intuitive and it looks like `maxTotalRows = maxTotalSegments * maxRowsPerSegment`. Then, maybe we can control `maxTotalRows` by setting `maxTotalSegments` and `maxRowsPerSegment` properly.
   
   So, I would suggest to replace `maxTotalRows` with `maxTotalSegments` rather than having both. I think they would be used in similar use cases and less configurations would be simpler for tuning. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org