You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/20 12:00:57 UTC
[GitHub] [iceberg] omarsmak opened a new pull request #3155: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
omarsmak opened a new pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155
Fixes #3041
As I explained [here](https://github.com/apache/iceberg/issues/3041#issuecomment-921917532), this issue seems happen as regression result from PR: https://github.com/apache/iceberg/pull/2613
So the issue is that compiled class `HiveVectorizedReader` refers to the shaded `org.apache.iceberg.shaded.org.apache.orc.OrcTail` instead of `org.apache.orc.OrcTail` which triggers the error that is described in the github issue when using Vectorized ORC with MR jobs.
Honestly, this is a bit annoying issue due to the inter-dependencies between Hive, Iceberg and ORC and therefore, the simplest solution is to copy `OrcTail` class from Hive 3.1.2 into Iceberg for this only case. However, to be honest I am not happy to copy such classes from Hive but from my humble understanding is that, such solution will be temporary until the release of Hive 4. Thus, I am submitting this PR for this purposed solution, if anybody has a better idea how to solve such issue, I will be happy to hear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on pull request #3155: Hive: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155#issuecomment-940819990
Renamed the PR title, and commit message to match the contents.
Thanks for the fix @omarsmak and @szlta for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3155: Hive: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155#issuecomment-947881809
Thanks, @omarsmak. I've added this to the 0.12.1 milestone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] omarsmak commented on pull request #3155: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
omarsmak commented on pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155#issuecomment-923870416
@szlta Checkstyle should be fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] omarsmak commented on pull request #3155: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
omarsmak commented on pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155#issuecomment-923828468
> LGTM, I'm okay with copying this over from Hive for the time being. Checkstyle errors need to be fixed though in the copied OrcSplit class.
Thanks for the feedback. Sure, I will fix the Checkstyle errors and update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary merged pull request #3155: Hive: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
pvary merged pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szlta commented on pull request #3155: ORC: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
szlta commented on pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155#issuecomment-940817717
LGTM, @pvary can you please take a look too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szlta commented on pull request #3155: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
szlta commented on pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155#issuecomment-940090754
Can you retrigger the tests? I still see some failures :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] omarsmak commented on pull request #3155: ORC: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
omarsmak commented on pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155#issuecomment-940229399
@szlta things look good now in the CI :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szlta commented on pull request #3155: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
szlta commented on pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155#issuecomment-923813191
LGTM, I'm okay with copying this over from Hive for the time being. Checkstyle errors need to be fixed though in the copied OrcSplit class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] omarsmak commented on pull request #3155: Hive: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
omarsmak commented on pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155#issuecomment-947842761
@rdblue I think this PR is a good candidate for 0.12.1 milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] omarsmak commented on pull request #3155: Fix NoSuchMethodError of OrcTail with Hive3.x and Vectorized ORC
Posted by GitBox <gi...@apache.org>.
omarsmak commented on pull request #3155:
URL: https://github.com/apache/iceberg/pull/3155#issuecomment-934241853
hey @szlta ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org